chore: coderabbit

formancehq · Jan 30, 2025 · b195cc0 · b195cc0
1 parent 0da77e0
commit b195cc0
Show file tree

Hide file tree

Showing 20 changed files with 11 additions and 56 deletions.
diff --git a/internal/api/bulking/mocks_ledger_controller_test.go b/internal/api/bulking/mocks_ledger_controller_test.go
diff --git a/internal/api/common/mocks_ledger_controller_test.go b/internal/api/common/mocks_ledger_controller_test.go
diff --git a/internal/api/common/mocks_system_controller_test.go b/internal/api/common/mocks_system_controller_test.go
diff --git a/internal/api/v1/mocks_ledger_controller_test.go b/internal/api/v1/mocks_ledger_controller_test.go
diff --git a/internal/api/v1/mocks_system_controller_test.go b/internal/api/v1/mocks_system_controller_test.go
diff --git a/internal/api/v2/mocks_ledger_controller_test.go b/internal/api/v2/mocks_ledger_controller_test.go
diff --git a/internal/api/v2/mocks_system_controller_test.go b/internal/api/v2/mocks_system_controller_test.go
diff --git a/internal/controller/ledger/controller_generated_test.go b/internal/controller/ledger/controller_generated_test.go
diff --git a/internal/controller/ledger/controller_with_too_many_client_handling_generated_test.go b/internal/controller/ledger/controller_with_too_many_client_handling_generated_test.go
diff --git a/internal/controller/ledger/listener_generated_test.go b/internal/controller/ledger/listener_generated_test.go
diff --git a/internal/controller/ledger/numscript_parser_generated_test.go b/internal/controller/ledger/numscript_parser_generated_test.go
diff --git a/internal/controller/ledger/numscript_runtime_generated_test.go b/internal/controller/ledger/numscript_runtime_generated_test.go
diff --git a/internal/controller/ledger/store_generated_test.go b/internal/controller/ledger/store_generated_test.go
diff --git a/internal/leadership/broadcaster.go b/internal/leadership/broadcaster.go
@@ -9,7 +9,7 @@ type listener struct {
 }
 
 type Broadcaster struct {
-	mu *sync.Mutex
+	mu sync.Mutex
 	t  *Leadership
 
 	inner []listener
@@ -81,6 +81,5 @@ func (h *Broadcaster) CountListeners() int {
 func NewSignal() *Broadcaster {
 	return &Broadcaster{
 		outer: make(chan Leadership),
-		mu:    &sync.Mutex{},
 	}
 }
diff --git a/internal/leadership/context.go b/internal/leadership/context.go
@@ -5,9 +5,9 @@ import (
 	"sync"
 )
 
-type contextKey string
+type contextKey struct{}
 
-var holderContextKey contextKey = "holder"
+var holderContextKey contextKey = struct{}{}
 
 func ContextWithLeadershipInfo(ctx context.Context) context.Context {
 	return context.WithValue(ctx, holderContextKey, &holder{})

diff --git a/internal/leadership/locker.go b/internal/leadership/locker.go
@@ -38,7 +38,7 @@ func (p *defaultLocker) Take(ctx context.Context) (DBHandle, error) {
 	var acquired bool
 	if err := ret.Scan(&acquired); err != nil {
 		_ = conn.Close()
-		panic(err)
+		return nil, err
 	}
 
 	if !acquired {

diff --git a/internal/leadership/manager_test.go b/internal/leadership/manager_test.go
@@ -43,6 +43,13 @@ func TestLeaderShip(t *testing.T) {
 		}
 		return false
 	}, 2*time.Second, 10*time.Millisecond)
+	leaderCount := 0
+	for _, manager := range instances {
+		if manager.GetSignal().Actual().Acquired {
+			leaderCount++
+		}
+	}
+	require.Equal(t, 1, leaderCount)
 	require.GreaterOrEqual(t, selectedLeader, 0)
 
 	// ensure the provided db connection is still functionnal

diff --git a/internal/storage/driver/buckets_generated_test.go b/internal/storage/driver/buckets_generated_test.go
diff --git a/internal/storage/driver/ledger_generated_test.go b/internal/storage/driver/ledger_generated_test.go
diff --git a/internal/storage/driver/system_generated_test.go b/internal/storage/driver/system_generated_test.go