Skip to content

Conversation

@Schamper
Copy link
Member

@Schamper Schamper commented Jul 30, 2023

Mostly experimental for now and requires benchmarking and profiling to see it it's worth pursuing this further. In some initial tests this turns out to be slower, but that's probably also because the rest of the chain (all containers and Dissect implementations) will use the _read fallback.

Also looks like PyPy is not happy about using memoryview.

The goal of this PR is to have a branch with which further testing can be performed to see if this is worthwhile.

@Schamper Schamper marked this pull request as draft July 30, 2023 14:27
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Attention: Patch coverage is 0% with 177 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (d9a1ccf) to head (2ca63aa).

Files with missing lines Patch % Lines
dissect/util/stream.py 0.00% 177 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #31   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         22      22           
  Lines       1362    1418   +56     
=====================================
- Misses      1362    1418   +56     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pyrco pyrco removed their request for review August 29, 2023 07:24
Schamper and others added 3 commits July 2, 2025 10:52
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
@Schamper Schamper force-pushed the alignedstream-readinto branch from 671d802 to 7a4b3e1 Compare July 2, 2025 08:54
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 2, 2025

CodSpeed Performance Report

Merging #31 will degrade performances by 27.14%

Comparing alignedstream-readinto (2ca63aa) with main (d9a1ccf)

Summary

❌ 2 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_aligned_stream_read_fixed_size_benchmark 49.6 µs 66.3 µs -25.19%
test_aligned_stream_read_none_size_benchmark 43.1 µs 59.2 µs -27.14%

@Schamper Schamper force-pushed the alignedstream-readinto branch from 7a4b3e1 to 2ca63aa Compare July 2, 2025 09:43
@Schamper Schamper mentioned this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants