-
Notifications
You must be signed in to change notification settings - Fork 7
Make AlignedStream readinto based #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 22 22
Lines 1362 1418 +56
=====================================
- Misses 1362 1418 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
43a0805 to
671d802
Compare
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
671d802 to
7a4b3e1
Compare
CodSpeed Performance ReportMerging #31 will degrade performances by 27.14%Comparing Summary
Benchmarks breakdown
|
7a4b3e1 to
2ca63aa
Compare
Mostly experimental for now and requires benchmarking and profiling to see it it's worth pursuing this further. In some initial tests this turns out to be slower, but that's probably also because the rest of the chain (all containers and Dissect implementations) will use the
_readfallback.Also looks like PyPy is not happy about using
memoryview.The goal of this PR is to have a branch with which further testing can be performed to see if this is worthwhile.