-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implementation of PBR in glTF #715
base: master
Are you sure you want to change the base?
Conversation
Very impressive !!! Emissive seems working very well. |
Sorry for the late reply @Garyfallidis, my school examinations were going on. I'll fix this ASAP. |
Ping @xtanion Let us know if you need a meeting to finalize this. |
@xtanion please provide feedback asap. |
Sorry for the late response, I was traveling this entire week. I'll be working on this from Friday. |
Great! Do you have any progress on this? if yes, can you push it? thank you @xtanion. ps: Also, it would be great if you could attend the fury open meeting this Thursday (March 30) |
ping @xtanion |
There are still some conflicts. Can you also list the remaining steps needed for this PR? @xtanion ? |
@xtanion a reminder to move forward with this PR. |
This PR needs a lot of cleaning and still in progress. As of now this PR adds ORM, Normal & Emissive materials. Most of the glTF models has been modified to use the ORM material, however few of them still use
MetallicRoughness
andAmbientOcclusion
materials separately (for e.g. DamagedHelmet & Avocado).Few model may have
RoughnessMetallic
instead ofMetallicRoughness
which changes switches the channels (For e.g. theAvocado
model), as mentioned in this comment. This PR currently does not support the RoughnessMetallic.Preview with the
DamagedHelmet
(has all three of materials) model:Sample of the
Avocado
model (without switching the channels inRoughnessMetallic
toMetallicRoughness
) ( Left)After switching channels (Right):