-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Adding FileDialog UI #832
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
==========================================
+ Coverage 84.49% 84.57% +0.07%
==========================================
Files 44 44
Lines 10454 10572 +118
Branches 1411 1419 +8
==========================================
+ Hits 8833 8941 +108
- Misses 1252 1257 +5
- Partials 369 374 +5
|
What is the update concerning this PR @ganimtron-10? |
I have fixed the issues which were crucial and needed in this PR. |
@tvcastillod and @JoaoDell, Can you look at this PR ? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ganimtron-10, overall it looks like this new FileDialog component is working fine so far.
I just want to understand better which issues you addressed and how did you fix them, for example, for the ZeroDivisionError I saw you fixed it by adding a condition over denom
variable, In which cases did this error occur before? or with the Overflow issue, what does it refer to? is it about the file names display?
Also, the example looks good, it's simple and easy to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ganimtron-10, I have just finished reviewing your PR. All the tests passed and the example shows well the feature you worked on. About the scripts, everything seems fine and well organized. Overall looks fine and ready to merge, so good job! I guess I just wanted to better understand the same details @tvcastillod pointed out in her review, as I checked the current folder's path indeed expands out of the textbox. Is it described somewhere in your blogposts?
Hey @JoaoDell @tvcastillod , |
Just checked your blogpost and I have no more questions. Also I noticed you have fixed the directory textblock clipping, so everything seems in place now, good job |
FileDialog is an important UI element needed for a variety of use case. Continuing #294 to add the required changes and updates.
TODO:
Resize for. -> in a new PRFileMenu2D
Resize for-> in a new PRFileDialog2D