simple code QA for a better scoring

[meltzow]

"we" want to have a full scoring. see https://pub.dev/packages/convenient_test/score ;-)

[meltzow]

oh we are using a line-length with 120 in our checks. It looks like, it's more as the checker for the pub.dev-scoring is using.
ok than I will revert my formatting things.

[meltzow]

just only 5 points more ;-)
because of removing insecure link in Readme.md

[fzyzcjy]

LGTM! It would be great to modify https://github.com/fzyzcjy/flutter_convenient_test/blob/master/.all-contributorsrc correspondingly, o/w the next time it will override the readme.

[fzyzcjy]

oh we are using a line-length with 120 in our checks. It looks like, it's more as the checker for the pub.dev-scoring is using.
ok than I will revert my formatting things.

No worries, we can format it to be 80. Indeed I have done so for https://github.com/fzyzcjy/flutter_rust_bridge for the pub scores (though I personally prefer 120).

[meltzow]

oh we are using a line-length with 120 in our checks. It looks like, it's more as the checker for the pub.dev-scoring is using.
ok than I will revert my formatting things.

No worries, we can format it to be 80. Indeed I have done so for https://github.com/fzyzcjy/flutter_rust_bridge for the pub scores (though I personally prefer 120).

this check will be failed if we format it to be 80:

flutter_convenient_test/.github/workflows/ci.yaml

Line 53 in 582bf48

run: dart format --set-exit-if-changed --line-length 120 .

[meltzow]

grrr ... this was a huge refactoring in a lot of files. the score-page (https://pub.dev/packages/convenient_test/score) displays formatting warnings in only 2 files. But after I started the reformatting in these 2 files, the CI failed.
Luckily it was a automatically done with a combination of "flutter analyze", "dart format . " and "dart fix --apply"
Please decide by your own, if this PR is needed and merged

[fzyzcjy]

this check will be failed if we format it to be 80

Just change the CI :)

[fzyzcjy]

@all-contributors please add @meltzow for code

[allcontributors]

@fzyzcjy

@meltzow already contributed before to code