simple code QA for a better scoring

.all-contributorsrc

@@ -119,7 +119,7 @@
       "login": "gnunicorn",
       "name": "Benjamin Kampmann",
       "avatar_url": "https://avatars.githubusercontent.com/u/40496?v=4",
-      "profile": "http://www.gnunicorn.org",
+      "profile": "https://gnunicorn.org",
       "contributions": [
         "code"
       ]

.github/workflows/ci.yaml

@@ -50,7 +50,7 @@ jobs:
         working-directory: packages/${{ matrix.package_name_and_runs_on.package_name }}
 
       - name: Check format
-        run: dart format --set-exit-if-changed --line-length 120 .
+        run: dart format --set-exit-if-changed .
         working-directory: packages/${{ matrix.package_name_and_runs_on.package_name }}
 
 # TODO fix it (seems GitHub Actions upgraded, making Fastlane confused)

README.md

@@ -306,7 +306,7 @@ For detailed PRs (excluding myself), please see [this link](https://github.com/f
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/gilice"><img src="https://avatars.githubusercontent.com/u/104317939?v=4?s=100" width="100px;" alt="gilice"/><br /><sub><b>gilice</b></sub></a><br /><a href="https://github.com/fzyzcjy/flutter_convenient_test/commits?author=gilice" title="Code">💻</a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/madmini"><img src="https://avatars.githubusercontent.com/u/26089559?v=4?s=100" width="100px;" alt="Max Jakobitsch"/><br /><sub><b>Max Jakobitsch</b></sub></a><br /><a href="https://github.com/fzyzcjy/flutter_convenient_test/commits?author=madmini" title="Code">💻</a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://keybase.io/jmatth"><img src="https://avatars.githubusercontent.com/u/1316184?v=4?s=100" width="100px;" alt="Josh Matthews"/><br /><sub><b>Josh Matthews</b></sub></a><br /><a href="https://github.com/fzyzcjy/flutter_convenient_test/commits?author=jmatth" title="Code">💻</a></td>
-      <td align="center" valign="top" width="14.28%"><a href="http://www.gnunicorn.org"><img src="https://avatars.githubusercontent.com/u/40496?v=4?s=100" width="100px;" alt="Benjamin Kampmann"/><br /><sub><b>Benjamin Kampmann</b></sub></a><br /><a href="https://github.com/fzyzcjy/flutter_convenient_test/commits?author=gnunicorn" title="Code">💻</a></td>
+      <td align="center" valign="top" width="14.28%"><a href="https://gnunicorn.org"><img src="https://avatars.githubusercontent.com/u/40496?v=4?s=100" width="100px;" alt="Benjamin Kampmann"/><br /><sub><b>Benjamin Kampmann</b></sub></a><br /><a href="https://github.com/fzyzcjy/flutter_convenient_test/commits?author=gnunicorn" title="Code">💻</a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/meltzow"><img src="https://avatars.githubusercontent.com/u/1238001?v=4?s=100" width="100px;" alt="Mario Meltzow"/><br /><sub><b>Mario Meltzow</b></sub></a><br /><a href="https://github.com/fzyzcjy/flutter_convenient_test/commits?author=meltzow" title="Code">💻</a></td>
     </tr>
   </tbody>

packages/convenient_test/example/integration_test/main_test.dart

@@ -68,14 +68,17 @@ void main() {
       tTestWidgets('golden test', (t) async {
         await find.text('HomePage').should(findsOneWidget);
 
-        await find.byType(MaterialApp).should(matchesGoldenFile('goldens/sample_golden.png'));
+        await find
+            .byType(MaterialApp)
+            .should(matchesGoldenFile('goldens/sample_golden.png'));
       });
 
       tTestWidgets('deliberately failed golden test', (t) async {
         await t.visit('/random');
         await find.text('RandomPage').should(findsOneWidget);
 
-        await find.get(RandomPageMark.randomText).should(matchesGoldenFile('goldens/deliberately_failed_golden.png'));
+        await find.get(RandomPageMark.randomText).should(
+            matchesGoldenFile('goldens/deliberately_failed_golden.png'));
 
         // let's assert something else
         await find.textContaining('Random Height').should(findsOneWidget);
@@ -146,11 +149,15 @@ void main() {
           await t.visit('/zoom');
           await t.pumpAndSettle();
 
-          await find.get(ZoomPageMark.palette).should(matchesGoldenFile('goldens/zoom_page_drag_before.png'));
+          await find
+              .get(ZoomPageMark.palette)
+              .should(matchesGoldenFile('goldens/zoom_page_drag_before.png'));
 
           await find.get(ZoomPageMark.palette).drag(const Offset(0, -50));
 
-          await find.get(ZoomPageMark.palette).should(matchesGoldenFile('goldens/zoom_page_drag_after.png'));
+          await find
+              .get(ZoomPageMark.palette)
+              .should(matchesGoldenFile('goldens/zoom_page_drag_after.png'));
 
           // alternative approach
           // await t.tester.drag(find.get(ZoomPageMark.palette), const Offset(0, -50));
@@ -163,17 +170,29 @@ void main() {
         tTestWidgets('double finger zooming', (t) async {
           await t.visit('/zoom');
 
-          await find.get(ZoomPageMark.palette).should(matchesGoldenFile('goldens/zoom_page_zoom_before.png'));
+          await find
+              .get(ZoomPageMark.palette)
+              .should(matchesGoldenFile('goldens/zoom_page_zoom_before.png'));
 
           await find.get(ZoomPageMark.palette).multiDrag(
                 firstDownOffset: const Offset(0, -30),
                 secondDownOffset: const Offset(0, 30),
-                firstFingerOffsets: const [Offset(0, -20), Offset(0, -20), Offset(0, -10)],
-                secondFingerOffsets: const [Offset(0, 20), Offset(0, 20), Offset(0, 10)],
+                firstFingerOffsets: const [
+                  Offset(0, -20),
+                  Offset(0, -20),
+                  Offset(0, -10)
+                ],
+                secondFingerOffsets: const [
+                  Offset(0, 20),
+                  Offset(0, 20),
+                  Offset(0, 10)
+                ],
                 logMove: true,
               );
 
-          await find.get(ZoomPageMark.palette).should(matchesGoldenFile('goldens/zoom_page_zoom_after.png'));
+          await find
+              .get(ZoomPageMark.palette)
+              .should(matchesGoldenFile('goldens/zoom_page_zoom_after.png'));
         });
       });
     });
@@ -199,7 +218,8 @@ class MyConvenientTestSlot extends ConvenientTestSlot {
   Future<void> appMain(AppMainExecuteMode mode) async => app.main();
 
   @override
-  BuildContext? getNavContext(ConvenientTest t) => MyApp.navigatorKey.currentContext;
+  BuildContext? getNavContext(ConvenientTest t) =>
+      MyApp.navigatorKey.currentContext;
 }
 
 extension on ConvenientTest {

packages/convenient_test/example/lib/home_page.dart

@@ -22,7 +22,8 @@ class _HomePageState extends State<HomePage> {
       floatingActionButton: Mark(
         name: HomePageMark.fab,
         child: FloatingActionButton(
-          onPressed: () => Navigator.pushNamed(context, '/second', arguments: chosenFruits),
+          onPressed: () =>
+              Navigator.pushNamed(context, '/second', arguments: chosenFruits),
           child: const Icon(Icons.done),
         ),
       ),
@@ -51,9 +52,12 @@ class _HomePageState extends State<HomePage> {
     return Column(
       children: [
         Padding(
-          padding: const EdgeInsets.only(top: 16, bottom: 4, left: 16, right: 16),
+          padding:
+              const EdgeInsets.only(top: 16, bottom: 4, left: 16, right: 16),
           child: Text(
-            chosenFruits.isEmpty ? 'You chose nothing' : 'You chose: ${chosenFruits.join(', ')}',
+            chosenFruits.isEmpty
+                ? 'You chose nothing'
+                : 'You chose: ${chosenFruits.join(', ')}',
             style: const TextStyle(fontSize: 16),
           ),
         ),
@@ -65,7 +69,9 @@ class _HomePageState extends State<HomePage> {
               return ListTile(
                 onTap: () => setState(() => chosenFruits.toggle(fruit)),
                 title: Text(fruit),
-                trailing: chosenFruits.contains(fruit) ? const Icon(Icons.star, color: Colors.blue) : null,
+                trailing: chosenFruits.contains(fruit)
+                    ? const Icon(Icons.star, color: Colors.blue)
+                    : null,
               );
             },
           ),

packages/convenient_test/example/lib/second_page.dart

@@ -27,8 +27,12 @@ class SecondPage extends StatelessWidget {
             Row(
               mainAxisSize: MainAxisSize.min,
               children: [
-                TextButton(onPressed: () => Navigator.pushNamed(context, '/timer'), child: const Text('GoTimerPage')),
-                TextButton(onPressed: () => Navigator.pushNamed(context, '/zoom'), child: const Text('GoZoomPage')),
+                TextButton(
+                    onPressed: () => Navigator.pushNamed(context, '/timer'),
+                    child: const Text('GoTimerPage')),
+                TextButton(
+                    onPressed: () => Navigator.pushNamed(context, '/zoom'),
+                    child: const Text('GoZoomPage')),
               ],
             ),
           ],

packages/convenient_test/example/lib/zoom_page.dart

@@ -48,7 +48,8 @@ class _ZoomPageState extends State<ZoomPage> {
                                 child: Container(
                                   width: 50,
                                   height: 50,
-                                  color: _getColor(Point(x, y), invert: _chosenPoint == Point(x, y)),
+                                  color: _getColor(Point(x, y),
+                                      invert: _chosenPoint == Point(x, y)),
                                   child: Center(
                                     child: Text('$x#$y'),
                                   ),

packages/convenient_test/lib/src/gesture_visualizer.dart

@@ -2,7 +2,10 @@ import 'package:flutter/material.dart';
 import 'package:flutter/rendering.dart';
 
 /// These are the parameters for the visualization of the recorded taps.
-final _kTapRadius = 15.0, _kTapColor = Colors.grey[300]!, _kShadowColor = Colors.black, _kShadowElevation = 3.0;
+final _kTapRadius = 15.0,
+    _kTapColor = Colors.grey[300]!,
+    _kShadowColor = Colors.black,
+    _kShadowElevation = 3.0;
 const _kRemainAfterPointerUp = Duration(milliseconds: 100);
 
 /// NOTE: refer to this answer for why use hitTest/handleEvent/etc https://stackoverflow.com/a/65067655
@@ -57,7 +60,8 @@ class _RenderGestureVisualizer extends RenderProxyBox {
         markNeedsPaint();
       });
     } else {
-      _recordedPointerInfoMap[event.pointer] = _RecordedPointerInfo(event.localPosition);
+      _recordedPointerInfoMap[event.pointer] =
+          _RecordedPointerInfo(event.localPosition);
       markNeedsPaint();
     }
   }
@@ -68,7 +72,9 @@ class _RenderGestureVisualizer extends RenderProxyBox {
 
     final canvas = context.canvas;
     for (final info in _recordedPointerInfoMap.values) {
-      final path = Path()..addOval(Rect.fromCircle(center: info.localPosition, radius: _kTapRadius));
+      final path = Path()
+        ..addOval(
+            Rect.fromCircle(center: info.localPosition, radius: _kTapRadius));
 
       canvas.drawShadow(path, _kShadowColor, _kShadowElevation, true);
       canvas.drawPath(path, Paint()..color = _kTapColor);

packages/convenient_test/lib/src/misc.dart

@@ -140,7 +140,10 @@ class Mark extends StatelessWidget {
   }
 
   String _onlyUpperOrFirstLetter(String s) {
-    return s.split('').whereIndexed((i, ch) => i == 0 || ch.toUpperCase() == ch).join('');
+    return s
+        .split('')
+        .whereIndexed((i, ch) => i == 0 || ch.toUpperCase() == ch)
+        .join('');
   }
 }
 

packages/convenient_test_common/lib/src/common_flutter/attachable_state_mixin.dart

@@ -3,15 +3,17 @@ import 'package:mobx/mobx.dart';
 
 mixin AttachableStateMixin<T> {
   T get state {
-    assert(isStateSingle, 'Want to get this.state but wrong number of _states. $attachableStateMixinInfo');
+    assert(isStateSingle,
+        'Want to get this.state but wrong number of _states. $attachableStateMixinInfo');
     return _states.single;
   }
 
   int get numStates => _states.length;
 
   bool get isStateSingle => numStates == 1;
 
-  String get attachableStateMixinInfo => 'AttachableStateMixin(runtimeType=$runtimeType, hash=$hashCode, '
+  String get attachableStateMixinInfo =>
+      'AttachableStateMixin(runtimeType=$runtimeType, hash=$hashCode, '
       '_states=$_states (their hashCodes: ${_states.map((s) => s.hashCode).toList()}))';
 
   List<T> get states => _states;
@@ -32,7 +34,8 @@ mixin AttachableStateMixin<T> {
   }
 }
 
-class AttachableStateAttacherWidget<T extends AttachableStateMixin<S>, S> extends StatefulWidget {
+class AttachableStateAttacherWidget<T extends AttachableStateMixin<S>, S>
+    extends StatefulWidget {
   final T target;
   final S state;
   final Widget child;
@@ -45,7 +48,8 @@ class AttachableStateAttacherWidget<T extends AttachableStateMixin<S>, S> extend
   });
 
   @override
-  _AttachableStateAttacherWidgetState<T, S> createState() => _AttachableStateAttacherWidgetState<T, S>();
+  _AttachableStateAttacherWidgetState<T, S> createState() =>
+      _AttachableStateAttacherWidgetState<T, S>();
 }
 
 class _AttachableStateAttacherWidgetState<T extends AttachableStateMixin<S>, S>
@@ -57,9 +61,11 @@ class _AttachableStateAttacherWidgetState<T extends AttachableStateMixin<S>, S>
   }
 
   @override
-  void didUpdateWidget(covariant AttachableStateAttacherWidget<T, S> oldWidget) {
+  void didUpdateWidget(
+      covariant AttachableStateAttacherWidget<T, S> oldWidget) {
     super.didUpdateWidget(oldWidget);
-    if (!identical(oldWidget.target, widget.target) || !identical(oldWidget.state, widget.state)) {
+    if (!identical(oldWidget.target, widget.target) ||
+        !identical(oldWidget.state, widget.state)) {
       oldWidget.target.detach(oldWidget.state);
       widget.target.attach(widget.state);
     }

packages/convenient_test_common/lib/src/common_flutter/image_decoder_widget.dart

@@ -3,7 +3,8 @@ import 'dart:ui' as ui;
 import 'package:flutter/material.dart';
 import 'package:flutter/scheduler.dart';
 
-typedef ImageDecoderBuilder<Tag> = Widget Function(BuildContext context, TaggedImageInfo<Tag>? info);
+typedef ImageDecoderBuilder<Tag> = Widget Function(
+    BuildContext context, TaggedImageInfo<Tag>? info);
 
 class ImageDecoderWidget<Tag> extends StatefulWidget {
   const ImageDecoderWidget({
@@ -42,7 +43,8 @@ class ImageDecoderWidget<Tag> extends StatefulWidget {
   final void Function(ui.Image? image)? onUiImage;
 
   @override
-  State<ImageDecoderWidget<Tag>> createState() => _ImageDecoderWidgetState<Tag>();
+  State<ImageDecoderWidget<Tag>> createState() =>
+      _ImageDecoderWidgetState<Tag>();
 }
 
 class _ImageDecoderWidgetState<Tag> extends State<ImageDecoderWidget<Tag>> {
@@ -70,19 +72,22 @@ class _ImageDecoderWidgetState<Tag> extends State<ImageDecoderWidget<Tag>> {
     final interestImageProvider = widget.imageProvider;
     final oldImageStreamWithListener = _imageStreamWithListener;
     _imageStreamWithListener = _ImageStreamWithListener(
-      interestImageProvider.inner.resolve(createLocalImageConfiguration(context)),
+      interestImageProvider.inner
+          .resolve(createLocalImageConfiguration(context)),
       ImageStreamListener(
-        (imageInfo, synchronousCall) =>
-            _updateImage(imageInfo, synchronousCall, imageProviderTag: interestImageProvider.tag),
+        (imageInfo, synchronousCall) => _updateImage(imageInfo, synchronousCall,
+            imageProviderTag: interestImageProvider.tag),
         // NOTE XXX add
         onError: widget.onError,
       ),
     );
 
     if (oldImageStreamWithListener != null) {
-      oldImageStreamWithListener.inner.removeListener(oldImageStreamWithListener.listener);
+      oldImageStreamWithListener.inner
+          .removeListener(oldImageStreamWithListener.listener);
     }
-    _imageStreamWithListener!.inner.addListener(_imageStreamWithListener!.listener);
+    _imageStreamWithListener!.inner
+        .addListener(_imageStreamWithListener!.listener);
 
     // NOTE XXX edit
     // if (_imageStream!.key != oldImageStream?.key) {
@@ -95,15 +100,18 @@ class _ImageDecoderWidgetState<Tag> extends State<ImageDecoderWidget<Tag>> {
     // }
   }
 
-  void _updateImage(ImageInfo imageInfo, bool synchronousCall, {required Tag imageProviderTag}) {
+  void _updateImage(ImageInfo imageInfo, bool synchronousCall,
+      {required Tag imageProviderTag}) {
     // print('hi _updateImage imageInfo=$imageInfo');
     setState(() {
       // Trigger a build whenever the image changes.
       // NOTE MODIFIED 推迟dispose #5256
       // _imageInfo?.inner.dispose();
       final oldImageInfo = _imageInfo;
-      SchedulerBinding.instance.addPostFrameCallback((_) => oldImageInfo?.inner.dispose());
-      _imageInfo = TaggedImageInfo(imageInfo, imageProviderTag: imageProviderTag);
+      SchedulerBinding.instance
+          .addPostFrameCallback((_) => oldImageInfo?.inner.dispose());
+      _imageInfo =
+          TaggedImageInfo(imageInfo, imageProviderTag: imageProviderTag);
       widget.onUiImage?.call(_imageInfo?.inner.image); // NOTE XXX add
     });
   }
@@ -112,7 +120,8 @@ class _ImageDecoderWidgetState<Tag> extends State<ImageDecoderWidget<Tag>> {
   void dispose() {
     // _imageStream?.removeListener(ImageStreamListener(_updateImage)); // NOTE XXX
     if (_imageStreamWithListener != null) {
-      _imageStreamWithListener!.inner.removeListener(_imageStreamWithListener!.listener);
+      _imageStreamWithListener!.inner
+          .removeListener(_imageStreamWithListener!.listener);
     }
     _imageInfo?.inner.dispose();
     _imageInfo = null;
@@ -134,7 +143,8 @@ class TaggedImageInfo<Tag> {
   const TaggedImageInfo(this.inner, {required this.imageProviderTag});
 
   @override
-  String toString() => 'TaggedImageInfo(inner: $inner, imageProviderTag: $imageProviderTag)';
+  String toString() =>
+      'TaggedImageInfo(inner: $inner, imageProviderTag: $imageProviderTag)';
 }
 
 @immutable
@@ -144,10 +154,12 @@ class TaggedImageProvider<Tag> {
 
   const TaggedImageProvider(this.inner, {required this.tag});
 
-  static TaggedImageProvider<Tag>? maybe<Tag>(ImageProvider? inner, {required Tag tag}) =>
+  static TaggedImageProvider<Tag>? maybe<Tag>(ImageProvider? inner,
+          {required Tag tag}) =>
       inner == null ? null : TaggedImageProvider(inner, tag: tag);
 
-  static TaggedImageProvider<Object?> noTag(ImageProvider inner) => TaggedImageProvider(inner, tag: null);
+  static TaggedImageProvider<Object?> noTag(ImageProvider inner) =>
+      TaggedImageProvider(inner, tag: null);
 }
 
 @immutable