Skip to content

Conversation

@jmchilton
Copy link
Member

I think each usage we catch should improve the reliability of all the tests that still hit Github since we're less likely to hit rate limits and such.

xref https://github.com/jmchilton/galaxy/actions/runs/19865852088/job/56928306462

FAILED lib/galaxy_test/api/test_tools.py::TestToolsApi::test_allow_uri_if_protocol_on_collection_with_deferred - AssertionError: Final state - error - not okay. Full response: {'model_class': 'History', 'id': '47dd087789ea7ece', 'name': 'test_history', 'deleted': False, 'purged': False, 'archived': False, 'url': '/api/histories/47dd087789ea7ece', 'published': False, 'count': 6, 'annotation': None, 'tags': [], 'update_time': '2025-12-02T17:19:23.358756', 'preferred_object_store_id': None, 'contents_url': '/api/histories/47dd087789ea7ece/contents', 'size': 182, 'user_id': 'adb5f5c93f827949', 'create_time': '2025-12-02T17:19:19.595928', 'importable': False, 'slug': None, 'username': 'user--bx--psu--edu', 'username_and_slug': None, 'genome_build': None, 'state': 'error', 'state_ids': {'new': [], 'upload': [], 'queued': [], 'running': [], 'ok': ['0a0a5bcd98edfdcc'], 'empty': [], 'error': ['ea20eed3125afe51'], 'paused': [], 'setting_metadata': [], 'failed_metadata': [], 'deferred': ['b533467cdeb50a18', '50c3a241189ab841'], 'discarded': []}, 'state_details': {'new': 0, 'upload': 0, 'queued': 0, 'running': 0, 'ok': 1, 'empty': 0, 'error': 1, 'paused': 0, 'setting_metadata': 0, 'failed_metadata': 0, 'deferred': 2, 'discarded': 0}}

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Copy link
Member

nsoranzo commented Dec 2, 2025

FAILED lib/galaxy_test/api/test_tools.py::TestToolsApi::test_allow_uri_if_protocol_on_deferred_input - AssertionError: assert 'This is a line of text.' == 'base64://VGhpcyBpcyBhIGxpbmUgb2YgdGV4dC4K'
  
  - base64://VGhpcyBpcyBhIGxpbmUgb2YgdGV4dC4K
  + This is a line of text.

seems a relevant API test failure.

@jmchilton
Copy link
Member Author

Yeah - that tool takes in URIs - shouldn't have been updated - thanks for the catch @nsoranzo !

@nsoranzo
Copy link
Member

nsoranzo commented Dec 6, 2025

test_allow_uri_if_protocol_on_collection_with_deferred is also failing.

@jmchilton jmchilton marked this pull request as ready for review December 7, 2025 14:13
@github-actions github-actions bot added this to the 26.0 milestone Dec 7, 2025
@jmchilton
Copy link
Member Author

Thanks @nsoranzo - I appreciate all the help.

@jmchilton jmchilton merged commit 216f061 into galaxyproject:dev Dec 7, 2025
60 of 67 checks passed
@github-actions
Copy link

github-actions bot commented Dec 7, 2025

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo deleted the deferred_uri_fixes branch December 7, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants