updated snpeff version, fixed gb parsing py script #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Sep 30, 2024
bgruening
reviewed
Sep 30, 2024
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
nsoranzo
reviewed
Oct 10, 2024
bgruening
changed the title
bgruening
reviewed
Oct 18, 2024
nsoranzo
reviewed
Oct 18, 2024
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
bgruening
reviewed
Oct 18, 2024
| @@ -1,11 +1,11 @@ | |||
| <tool id="snpEff_build_gb" name="SnpEff build:" version="@WRAPPER_VERSION@.galaxy6" profile="22.01"> | |||
| <tool id="snpEff_build_gb" name="SnpEff build:" version="@SNPEFF_VERSION@+galaxy@WRAPPER_VERSION@" profile="23.0"> | |||
There was a problem hiding this comment.
instead of SNPEFF_VERSION could you please use TOOL_VERSION - https://galaxy-iuc-standards.readthedocs.io/en/latest/best_practices/tool_xml.html#tool-versions and also use @VERSION_SUFFIX@
this will help our bot with autoupdates.
bgruening
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR: