Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanpy1.10.2 update1 #6413

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Conversation

nilchia
Copy link
Contributor

@nilchia nilchia commented Oct 4, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

This PR updates two things:

  1. adds get.rank_genes_groups_df function so the user will get the ranked genes table as a tabular file.
  2. adds missing gene_symbols to pl.pca, pl.umap, and pl.diffmap

Thank you @nomadscientist for your suggestion. I hope it helps.

@nilchia nilchia marked this pull request as draft October 4, 2024 10:24
@pavanvidem
Copy link
Member

Please make sure that it will not break the GTA tutorials. Otherwise, we will merge this after the GTA.

@nilchia nilchia marked this pull request as ready for review October 4, 2024 12:11
@nilchia
Copy link
Contributor Author

nilchia commented Oct 4, 2024

@pavanvidem I guess it'll conflict with GTA.

@pavanvidem
Copy link
Member

Then please mark it as a draft and let it open at least until the end of next week.

@nilchia nilchia marked this pull request as draft October 4, 2024 16:09
@nilchia nilchia marked this pull request as ready for review October 14, 2024 09:30
@nilchia
Copy link
Contributor Author

nilchia commented Oct 14, 2024

@pavanvidem @bgruening
Thanks!

@bgruening
Copy link
Member

@nilchia you need to bump the version number.

@nilchia
Copy link
Contributor Author

nilchia commented Oct 18, 2024

@bgruening Is it OK now?

@bgruening bgruening merged commit 55ba4cd into galaxyproject:main Oct 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants