Fix examples and files with invalid extra diffuse values #419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Following the Building Your Own Robot tutorial I encountered an error when adding the caster wheel:
It appears an extra 1 is at the end, removing it allows Gazebo to run.
I used
grep -rl "<diffuse>0.0 1 0.0 1 1</diffuse>"
to find instances where this was present and removed the trailing 1 from them.I've tested this by attempting to run Gazeebo with the SDF files, both after and before the changes of this PR (though
citadel/tutorials/sensors/sensor_tutorial.sdf
appears to be unusable either way). E.g.:It might be useful to add a test to use gz to parse the SDF files, but I'm not sure where the test setup is for this repository (I don't want to ignore it and cause unintended maintenance issues 😅)
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.