Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that Gazebo Fortress is recommended for ROS 2 Humble and Iron users #437

Merged
merged 1 commit into from
May 7, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented May 7, 2024

🦟 Bug fix

Summary

The "Recommended" label on Harmonic can be confusing since we don't actually recommend it for use with ROS 2 Humble or Iron.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

cc @knmcguire, @Ryanf55

…n users

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from mabelzhang as a code owner May 7, 2024 22:31
@Ryanf55
Copy link

Ryanf55 commented May 7, 2024

Nice, this clears up the confusion for me.

@azeey azeey merged commit 7ff5e4f into gazebosim:master May 7, 2024
2 checks passed
@azeey azeey deleted the fix_get_started branch May 7, 2024 22:51
@knmcguire
Copy link
Contributor

Great! That will improve things. Thanks @azeey !

azeey added a commit to azeey/docs that referenced this pull request Jun 4, 2024
…n users (gazebosim#437)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants