Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 24, 2025

🦟 Bug fix

Fixes #559

Summary

Replicate warning:

  1. Go to https://build.osrfoundation.org/job/gz_sensors-ci-gz-sensors10-homebrew-amd64 before the merge
  2. Build the job
  3. See the warning appear

Changes made

-        const auto svdDecomposition =
-            beamBasis.topRows(numBeamsLocked).jacobiSvd(
-                Eigen::ComputeThinU | Eigen::ComputeThinV);

+        const Eigen::MatrixXd svdMat =
+          beamBasis.topRows(numBeamsLocked).eval();
+        using SvdT = Eigen::JacobiSVD<Eigen::MatrixXd>;
+        const SvdT svdDecomposition(svdMat,
+          Eigen::ComputeThinU | Eigen::ComputeThinV);

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)
    This is an automatic backport of pull request Fix: updated jacobi as template #560 done by Mergify.

Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
(cherry picked from commit 961e2f6)
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
(cherry picked from commit f048f92)
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
(cherry picked from commit 2cda290)
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
(cherry picked from commit b59d445)
@mergify mergify bot requested a review from iche033 as a code owner November 24, 2025 19:52
@mergify mergify bot mentioned this pull request Nov 24, 2025
9 tasks
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Nov 25, 2025
@scpeters scpeters merged commit 45ab665 into main Nov 25, 2025
13 checks passed
@scpeters scpeters deleted the mergify/bp/main/pr-560 branch November 25, 2025 23:57
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Nov 25, 2025
@scpeters
Copy link
Member

oops I should have squashed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants