Use the VS Code internal viewer only of the plot pane is enabled #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the plot pane is disabled, VS Code neither shows the plot nor prints any warning/error. The plot is not shown because Gnuplot.jl thinks the VS Code can display it. We fix that by adding a check for whether the pane is enabled. This is not an ideal solution because the check is executed only when loading Gnuplot.jl. If the panel is disabled later in the REPL session, no plots will be shown. If this turns out to be a problem, we will need to extend `showable` and perform the check there. The problem of not showing a warning/error when the plot pane is disabled must be addressed in julia-vscode. It seems that the Plots package doesn't produce any warning/error in this case too. Related to gcalderone#45.
|
If #47 gets merged, this is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the plot pane is disabled, VS Code neither shows the plot nor
prints any warning/error. The plot is not shown because Gnuplot.jl
thinks the VS Code can display it. We fix that by adding a check for
whether the pane is enabled.
This is not an ideal solution because the check is executed only when
loading Gnuplot.jl. If the panel is disabled later in the REPL
session, no plots will be shown. If this turns out to be a problem, we
will need to extend
showableand perform the check there.The problem of not showing a warning/error when the plot pane is
disabled must be addressed in julia-vscode. It seems that the Plots
package doesn't produce any warning/error in this case too.
Related to #45.