Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the VS Code internal viewer only of the plot pane is enabled #46

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use the VS Code internal viewer only of the plot pane is enabled #46

wants to merge 1 commit into from

Commits on Jul 29, 2021

  1. Use the VS Code internal viewer only of the plot pane is enabled 

    When the plot pane is disabled, VS Code neither shows the plot nor
prints any warning/error. The plot is not shown because Gnuplot.jl
thinks the VS Code can display it. We fix that by adding a check for
whether the pane is enabled.

This is not an ideal solution because the check is executed only when
loading Gnuplot.jl. If the panel is disabled later in the REPL
session, no plots will be shown. If this turns out to be a problem, we
will need to extend `showable` and perform the check there.

The problem of not showing a warning/error when the plot pane is
disabled must be addressed in julia-vscode. It seems that the Plots
package doesn't produce any warning/error in this case too.

Related to gcalderone#45.
    @wentasah
    wentasah committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    9044daf View commit details
    Browse the repository at this point in the history