Skip to content

Conversation

Leguark
Copy link
Member

@Leguark Leguark commented Sep 25, 2025

Description

Refactored the regular_grid method to use the previously defined boolean variables dense_grid_exists_and_active and octree_grid_exists_and_active for consistency and improved readability, instead of directly checking if the grid objects are not None.

Relates to #grid-refactoring

Checklist

  • My code uses type hinting for function and method arguments and return values.
  • I have created tests which cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New tests pass locally with my changes.

@Leguark Leguark marked this pull request as ready for review September 25, 2025 12:19
@graphite-app graphite-app bot added the gempy 3 Will come with the next major update label Sep 25, 2025
Copy link

graphite-app bot commented Sep 25, 2025

Graphite Automations

"Add gempy label" took an action on this PR • (09/25/25)

1 label was added to this PR based on Miguel de la Varga's automation.

@Leguark Leguark force-pushed the chages_for_server_II branch from 1b8b160 to 7ff3e14 Compare September 29, 2025 14:13
@Leguark Leguark force-pushed the serialize_hecho branch 2 times, most recently from 6348004 to 45ce60e Compare September 30, 2025 06:43
@Leguark Leguark force-pushed the chages_for_server_II branch from 7ff3e14 to 2db89de Compare September 30, 2025 06:43
Copy link
Member Author

Leguark commented Sep 30, 2025

Merge activity

@Leguark Leguark force-pushed the serialize_hecho branch 2 times, most recently from d2db5c0 to fd5675f Compare September 30, 2025 08:38
@Leguark Leguark changed the base branch from serialize_hecho to graphite-base/1062 September 30, 2025 09:04
@Leguark Leguark force-pushed the chages_for_server_II branch from 2db89de to e0ec8ca Compare September 30, 2025 09:04
@graphite-app graphite-app bot changed the base branch from graphite-base/1062 to main September 30, 2025 09:04
Updated the grid selection logic to use `dense_grid_exists_and_active` and `octree_grid_exists_and_active` checks instead of direct `None` comparisons for consistency and readability.
@Leguark Leguark force-pushed the chages_for_server_II branch from e0ec8ca to ed18b1f Compare September 30, 2025 09:04
@Leguark Leguark merged commit f62dfe5 into main Sep 30, 2025
2 checks passed
@Leguark Leguark deleted the chages_for_server_II branch September 30, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gempy 3 Will come with the next major update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant