Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.2.0 update to master #98

Merged
merged 58 commits into from
Jan 16, 2025
Merged

5.2.0 update to master #98

merged 58 commits into from
Jan 16, 2025

Conversation

erik-brink
Copy link
Collaborator

@erik-brink erik-brink commented Jan 9, 2025

Contents

The What

This PR is the collection of commits that make up the 5.2.0 version (Violet). This should be merged after #97, #96 and #94. Optionally #93 (PyPi publish GH Actions workflow)

The status of the PR will go from draft to open when all of the PRs mentioned above are merged

Summary (by Copilot)

This pull request introduces several significant improvements and new functionalities to the NGPIris project, including enhancements to object listing and searching, as well as the addition of a new GitHub workflow for type checking with PyType.

Enhancements to object listing and searching:

  • NGPIris/cli/__init__.py: Updated the _list_objects_generator function to include new parameters path and files_only, and modified the logic to filter objects based on these parameters. Added a new helper function add_trailing_slash to ensure paths end with a slash. Enhanced the list_objects and simple_search commands with new options for pagination, file-only output, and verbose output. Introduced a new fuzzy_search command for fuzzy searching in buckets. [1] [2] [3] [4] [5] [6]

  • NGPIris/hcp/hcp.py: Updated the list_objects method to include the files_only parameter and adjusted the filtering logic accordingly. Added a new fuzzy_search_in_bucket method using the RapidFuzz library for fuzzy searching. Improved error handling in delete_folder and upload_file methods. [1] [2] [3] [4] [5] [6] [7] [8]

Addition of PyType workflow:

  • .github/workflows/pytype.yml: Added a new GitHub Actions workflow to run PyType for type checking on the dev and master branches, ensuring code quality and type safety.

This update is:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Test Procedure

Installation and initiation

pip install NGPIris

Tests

Tests can as of right now, only be performed using pytest on a local instance of Iris. CI/CD for this is currently not possible.

Expected outcome:

PyTest resolves without crashes

Confirmations:

@erik-brink erik-brink requested a review from sylvinite January 9, 2025 08:28
@erik-brink erik-brink self-assigned this Jan 9, 2025
@erik-brink erik-brink marked this pull request as ready for review January 16, 2025 10:04
@erik-brink erik-brink removed the request for review from sylvinite January 16, 2025 15:03
@erik-brink erik-brink merged commit c8926fc into master Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant