-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.2.0 update to master #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d9dce1f.
Add automated PyType Github action
…-search Add fuzzy search and general CLI improvements
5.2.0 update to dev
Update test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
The What
This PR is the collection of commits that make up the 5.2.0 version (Violet). This should be merged after #97, #96 and #94. Optionally #93 (PyPi publish GH Actions workflow)
The status of the PR will go from draft to open when all of the PRs mentioned above are merged
Summary (by Copilot)
This pull request introduces several significant improvements and new functionalities to the
NGPIris
project, including enhancements to object listing and searching, as well as the addition of a new GitHub workflow for type checking with PyType.Enhancements to object listing and searching:
NGPIris/cli/__init__.py
: Updated the_list_objects_generator
function to include new parameterspath
andfiles_only
, and modified the logic to filter objects based on these parameters. Added a new helper functionadd_trailing_slash
to ensure paths end with a slash. Enhanced thelist_objects
andsimple_search
commands with new options for pagination, file-only output, and verbose output. Introduced a newfuzzy_search
command for fuzzy searching in buckets. [1] [2] [3] [4] [5] [6]NGPIris/hcp/hcp.py
: Updated thelist_objects
method to include thefiles_only
parameter and adjusted the filtering logic accordingly. Added a newfuzzy_search_in_bucket
method using theRapidFuzz
library for fuzzy searching. Improved error handling indelete_folder
andupload_file
methods. [1] [2] [3] [4] [5] [6] [7] [8]Addition of PyType workflow:
.github/workflows/pytype.yml
: Added a new GitHub Actions workflow to run PyType for type checking on thedev
andmaster
branches, ensuring code quality and type safety.This update is:
Test Procedure
Installation and initiation
Tests
Tests can as of right now, only be performed using
pytest
on a local instance of Iris. CI/CD for this is currently not possible.Expected outcome:
PyTest resolves without crashes
Confirmations: