PB-1383: Typescript+Pinia migration #1420
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-PB-1383-pinia-store
branch
5 times, most recently
from
69171a7 to
bdd5620
Compare
pakb
force-pushed
the
feat-PB-1383-pinia-store
branch
2 times, most recently
from
0e50331 to
f3e9cae
Compare
this is it, no more JS 🎉
pakb
force-pushed
the
feat-PB-1383-pinia-store
branch
from
448f1a4 to
2393419
Compare
The idea was to have one action per file, and share the reference to the store anyway (through this). I found this solution on Pinia GitHub tracker vuejs/pinia#983 (comment) a bit verbose/boilerplate, but that makes it way clearer what is happening in an action, especially now that we want to move all the "complex interactions" the plugins were doing into the store itself.
PB-1979: re-arrange app store into multiple files
PB-1979: re-arrange cesium store into multiple files
PB-1383: refactor share store
PB-1979: re-arrange debug store into multiple files
Make it returns the same function type/signature as the one given as input
pakb
force-pushed
the
feat-PB-1383-pinia-store
branch
from
fc5442f to
639f478
Compare
and try to fix a couple problems found while trying to draw something on the map
and make the options truly optional.
PB-1979: re-arrange drawing store into multiple files
and remove now obsolete Vite patch (the issue with Cypress+tsx+sass should be fixed in Vite 7.2.0) moving our patch for OL in a proper patch, instead of shallow-copying the file in our codebase
Also keeping track of the last selected color/size, and re-applying it for future drawing feature added by the drawing module (if you've selected blue for your current feature, the next you draw will also be blue)
PB-2027: fix icon/text edit popup not working since refactor
Issue: When trying to access the app, if there were external layers, they wouldn't be taken into account and not loaded. Fix: We remove a check that bypassed the addition of layers to the store at startup.
PB-2027: fix text placement when drawing a marker
Issue: When parsing external layers, if we encountered a layer with a sublayer, and both had an identical name, we would enter an infinite loop as we would be finding the base layer over and over again when going through the child to get valid layers. Temporary fix: If we have sublayers, we only go through the loop if those sublayers have sublayers. Next step : A more elegant solution would be preferable, as this can still fail if the sublayer has the same name as the base layer and has sub layers of its own.
…irect-in-tests PB-1383: infinite redirect when external layers have sublayers with the same name
…opic-reload PB-2064: load layers lang topic reload
and fix some TS error found in legacyParamImport.cy.ts
sommerfe
force-pushed
the
feat-PB-1383-pinia-store
branch
2 times, most recently
from
a1cccff to
9e6d8d7
Compare
while debugging a GPX file from a user, I fixed two issues regarding 3D and GPX: - 3D viewer had some artifacts on the terrain tiles, I disabled some post-processing operation and they were gone - the GPX file parser wasn't giving any "gpxFileUrl" for local files, and the creation of the layer was raising an error (failing the parsing)
and update the license/version to match our first attempt at publishing some code to npmjs.com 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link