Use tiff Tag enum from tiff crate #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use tiff::tags::Tag (https://docs.rs/tiff/0.9.1/tiff/tags/enum.Tag.html) instead of the TIFFTag enum in src/lowlevel.rs. Removed the decode_tag function, use `tiff::tags::Tag::from_u16` instead.
Use tiff::tags::Tag instead. Not removing yet because some of the TIFFTag enum variants should be ported upstream.
Planning to deprecate `crate::lowlevel::TIFFTag`, so validation should be handled upstream and based on tiff::tags::Tag instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to use
tiff::tags::Taginstead of the in-housecrate::lowlevel::TIFFTagenum.Breaking backward compatibility by:
decode_tagfunction, usetiff::tags::Tag::from_u16instead.validate_required_tags_forfunction, no direct replacement, but this should really be handled upstream by the image-tiff crate.Deprecation warnings on:
TIFFTagenum. Will remove once all of the tag variants been migrated upstream, xref Support additional tags image-rs/image-tiff#47.Part of #7.