Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tiff Tag enum from tiff crate #14

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Use tiff Tag enum from tiff crate #14

merged 4 commits into from
Jul 22, 2024

Commits on Jul 22, 2024

  1. Use tiff Tag enum from tiff crate 

    Use tiff::tags::Tag (https://docs.rs/tiff/0.9.1/tiff/tags/enum.Tag.html) instead of the TIFFTag enum in src/lowlevel.rs.  Removed the decode_tag function, use `tiff::tags::Tag::from_u16` instead.
    @weiji14
    weiji14 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6158cc2 View commit details
    Browse the repository at this point in the history

  2. Set deprecation warning on lowlevel::TIFFTag 

    Use tiff::tags::Tag instead. Not removing yet because some of the TIFFTag enum variants should be ported upstream.
    @weiji14
    weiji14 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    a7696a7 View commit details
    Browse the repository at this point in the history

  3. Remove validate_required_tags_for function 

    Planning to deprecate `crate::lowlevel::TIFFTag`, so validation should be handled upstream and based on tiff::tags::Tag instead.
    @weiji14
    weiji14 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    fb16cff View commit details
    Browse the repository at this point in the history

  4. Remove unused import of HashSet

    @weiji14
    weiji14 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    fbc6702 View commit details
    Browse the repository at this point in the history