-
Notifications
You must be signed in to change notification settings - Fork 71
Simplify CI #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CI #204
Conversation
914adec to
b16eb2e
Compare
|
I've also added caching to try to speed things up. Notably, the 1.63 job currently takes 6 minutes (vs around 1 minute for the 1.8x job), presumably due to the older index crates.io sync mechanism |
|
Ah, the I'll have to fix this on the geo side and build new images before we can merge this. |
f27ea05 to
9c46f30
Compare
|
What actually happened: I added the |
1859fc2 to
1e1effa
Compare
|
Whatever about this PR, the crate currently won't build locally for me on |
defaults:
run:
working-directory: rstarI think this is all due to I think we should just adjust the CI jobs accordingly: The Rust version matrix should only apply to the library crate itself (arguably even tests are out of scope for MSRV builds, but it is nice to have them working, e.g. for packaging in distros). The other checks like Rustfmt and Clippy should apply to the whole workspace. |
b6a7ab0 to
0753702
Compare
b982b9e to
ee5ca63
Compare
|
Seems sensible, and runs are all completing with the new setup. |
We no longer use cargo-all-features in geo, and rstar doesn't currently have any features, so this strategy needlessly inflates our test times.
We no longer use
cargo-all-featuresin geo, and rstar doesn't currently have any features, so this strategy needlessly inflates our test times.Also bumps Docker images to test on Rust 1.83 and 1.84, retaining 1.63
rstar/CHANGELOG.mdif knowledge of this change could be valuable to users.