Skip to content

Conversation

@urschrei
Copy link
Member

We no longer use cargo-all-features in geo, and rstar doesn't currently have any features, so this strategy needlessly inflates our test times.

Also bumps Docker images to test on Rust 1.83 and 1.84, retaining 1.63

  • I agree to follow the project's code of conduct.
  • I added an entry to rstar/CHANGELOG.md if knowledge of this change could be valuable to users.

@urschrei urschrei force-pushed the simplify_ci branch 2 times, most recently from 914adec to b16eb2e Compare August 16, 2025 21:01
@urschrei
Copy link
Member Author

I've also added caching to try to speed things up. Notably, the 1.63 job currently takes 6 minutes (vs around 1 minute for the 1.8x job), presumably due to the older index crates.io sync mechanism

@urschrei
Copy link
Member Author

Ah, the workspace directive is causing the build to break because geo is using the old API which borrowed geometries (changed in #189).

I'll have to fix this on the geo side and build new images before we can merge this.

@urschrei
Copy link
Member Author

urschrei commented Aug 18, 2025

A new error after rebasing onto #207: build failure on 1.63 due to rayon 1.11 but according to cargo tree rayon is only required by criterion, and that's v1.8.1 (rayon-core v1.12.1). It's not a default feature of geo-types, and we're not using the multithreading feature in rstar-benches.

What actually happened: I added the workspace switch to rstar-benches.

@urschrei urschrei force-pushed the simplify_ci branch 10 times, most recently from 1859fc2 to 1e1effa Compare August 20, 2025 10:16
@urschrei
Copy link
Member Author

urschrei commented Aug 20, 2025

Whatever about this PR, the crate currently won't build locally for me on master using its MSRV (repro: cargo +1.63 build) due to numerous packages requiring newer rustc. I'm confused as to how it's able to be built on our current 1.63 CI though (e.g. https://github.com/georust/rstar/actions/runs/17073341598/job/48407974736)

@adamreichold
Copy link
Member

Whatever about this PR, the crate currently won't build locally for me on master using its MSRV (repro: cargo +1.63 build) due to numerous packages requiring newer rustc. I'm confused as to how it's able to be built on our current 1.63 CI though (e.g. https://github.com/georust/rstar/actions/runs/17073341598/job/48407974736)

defaults:
  run:
    working-directory: rstar

I think this is all due to --workspace, meaning we did not build test rstar-benches etc. on the MSRV before. Building only the library crate itself still works locally for me, but benchmarks and demo fails as you experience here.

I think we should just adjust the CI jobs accordingly: The Rust version matrix should only apply to the library crate itself (arguably even tests are out of scope for MSRV builds, but it is nice to have them working, e.g. for packaging in distros). The other checks like Rustfmt and Clippy should apply to the whole workspace.

@urschrei urschrei force-pushed the simplify_ci branch 2 times, most recently from b6a7ab0 to 0753702 Compare August 28, 2025 22:32
@urschrei urschrei force-pushed the simplify_ci branch 2 times, most recently from b982b9e to ee5ca63 Compare August 28, 2025 22:55
@urschrei
Copy link
Member Author

Seems sensible, and runs are all completing with the new setup.

We no longer use cargo-all-features in geo, and rstar doesn't currently have any features, so this strategy needlessly inflates our test times.
@urschrei urschrei added this pull request to the merge queue Nov 9, 2025
Merged via the queue into master with commit 3fc595b Nov 9, 2025
6 checks passed
@urschrei urschrei deleted the simplify_ci branch November 9, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants