fix: implement getblock and getblockheader compliant with core
#657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
jaoleal
suggested changes
Oct 4, 2025
Collaborator
jaoleal
left a comment
jaoleal
left a comment
There was a problem hiding this comment.
I know that this is draft and the CI is broken but heres some early thougths
Davidson-Souza
added
code quality
qlrd
force-pushed
the
fix/getblockheader
branch
5 times, most recently
from
c469ea6 to
d80d2a8
Compare
qlrd
force-pushed
the
fix/getblockheader
branch
5 times, most recently
from
6c516c7 to
14f7841
Compare
qlrd
force-pushed
the
fix/getblockheader
branch
2 times, most recently
from
4a203b9 to
2a0ef75
Compare
Member
|
Needs rebase |
qlrd
force-pushed
the
fix/getblockheader
branch
3 times, most recently
from
a8fda04 to
4bcae5d
Compare
16 tasks
qlrd
force-pushed
the
fix/getblockheader
branch
5 times, most recently
from
cf053b0 to
1a77099
Compare
qlrd
force-pushed
the
fix/getblockheader
branch
3 times, most recently
from
94eb268 to
6f6d1e2
Compare
qlrd
changed the title
getblock and getblockheader compliant with core
qlrd
force-pushed
the
fix/getblockheader
branch
3 times, most recently
from
3953d6e to
757a88c
Compare
Member
Collaborator
Author
Collaborator
|
Need rebase |
7 tasks
Collaborator
|
Staled PR, @qlrd do you plan to continue this ? With the most recent changes i think that things are much simpler, take a look at our headers extensions in floresta-chain so we can get |
This commit add a `verbose` paramenter to `getblockheader` command so it will comply with core wheather to return a "raw" blockheader (as a hexadecimal string) or a "verbose" blockheader (as a json object). Fix getfloresta#655
This commit add a test that should result in a proper `serde_json::Value<GetBlockHeaderResVerbose>`.
…ock` rpc This commit add a cycle of connections and mining to the `getblockheader`/`getblock` tesst so it can check the blocks/ blockheaders for 102 different heights.
qlrd
force-pushed
the
fix/getblockheader
branch
from
757a88c to
8ef936f
Compare
This commit remove unused imports as well add a ignore pattern to .gitignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description and Notes
Fix #655
How to verify the changes you have done?
Add a
verboseparamenter togetblockheadercommand so it will comply with core wheather to return a "raw" blockheader (as a hexadecimal string) or a "verbose" blockheader (as a json object).Due to this, it was also needed to fix
getblockrpc method so it can, now, use verbosity levels0up to2.