[Chore] Justfile groups #676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaoleal
force-pushed
the
justfile_groups
branch
from
73e0ae3 to
965708a
Compare
Collaborator
Author
|
Sorry, there was a typo. CC @JoseSK999. The groups i mentioned in #661 |
jaoleal
force-pushed
the
justfile_groups
branch
from
ed677cf to
9a37344
Compare
Davidson-Souza
added
enhancement
Contributor
|
LGTM |
Member
Is there linting for |
JoseSK999
suggested changes
Oct 21, 2025
doc/justfile.md
Outdated
| # Just Recipes on Floresta. | ||
|
|
||
|
|
||
| In floresta we love to use [Just](https://just.systems/man/en/), its fast and a easy way to maintain scripts in the project. |
Member
There was a problem hiding this comment.
The unresolved cold-hearted nit from Davidson
jaoleal
force-pushed
the
justfile_groups
branch
from
9a37344 to
43605a3
Compare
Collaborator
Author
jaoleal
force-pushed
the
justfile_groups
branch
2 times, most recently
from
e803a24 to
1584f15
Compare
Collaborator
Author
|
Applied suggestions on 1584f15 The diff is really messed but im almost certain that i didnt overwrote anything |
Collaborator
Author
|
Some review here guys ? @Davidson-Souza @JoseSK999 @moisesPompilio |
jaoleal
force-pushed
the
justfile_groups
branch
from
1584f15 to
f1b49aa
Compare
Collaborator
Author
|
What... the docker build have random failure ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description and Notes
Part of #661
This proposes a set of justfile groups as well documentation for them.
What yall think of adding linting for justfile into CI ?
How to verify the changes you have done?
I created a new
docs/justfile.mdthat explains the groups and what they mean so,read
docs/justfile.mdand judge wheter they are concise and meaningfull.Theres new docs about justfile in
CONTRIBUTING,READMEanddocs/README. These should be instructions for a contributor or a developer to understand the scripts we have.Contributor Checklist
just pcc(recommended but slower)just lint-features '-- -D warnings' && cargo test --releaseFinally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).