Introduce HeaderExtension to centralize header-related logic #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaoleal
suggested changes
Dec 2, 2025
Collaborator
jaoleal
left a comment
jaoleal
left a comment
There was a problem hiding this comment.
Strong ACK.
Here some suggestion, nice idea @Davidson-Souza.
Member
|
Extension traits usually have the suffix |
moisesPompilio
force-pushed
the
add-block-ext
branch
from
bb2d635 to
2e30e65
Compare
16 tasks
moisesPompilio
force-pushed
the
add-block-ext
branch
2 times, most recently
from
4bab62b to
42f37f3
Compare
Davidson-Souza
requested changes
Dec 3, 2025
moisesPompilio
force-pushed
the
add-block-ext
branch
from
42f37f3 to
ed26800
Compare
17 tasks
moisesPompilio
force-pushed
the
add-block-ext
branch
from
ed26800 to
96fd6b6
Compare
jaoleal
reviewed
Dec 4, 2025
Collaborator
jaoleal
left a comment
jaoleal
left a comment
There was a problem hiding this comment.
just more these and i think well be at the finals
moisesPompilio
force-pushed
the
add-block-ext
branch
2 times, most recently
from
3d84e46 to
88acd41
Compare
jaoleal
approved these changes
Dec 6, 2025
moisesPompilio
force-pushed
the
add-block-ext
branch
3 times, most recently
from
6503a07 to
f9821eb
Compare
JoseSK999
reviewed
Dec 11, 2025
jaoleal
reviewed
Dec 13, 2025
moisesPompilio
force-pushed
the
add-block-ext
branch
from
f9821eb to
82e545c
Compare
moisesPompilio
force-pushed
the
add-block-ext
branch
3 times, most recently
from
8e8d56a to
31bdd1d
Compare
Collaborator
Author
|
@jaoleal I implemented your code suggestion, but I had to make some small changes because there were some errors in the chunking function you used, so I had to adjust that part. |
- Added methods for calculating median time past, chain work, and retrieving block details.
- Introduced HeaderExtension trait for improved header operations. - Updated GetBlockResVerbose to use f64 for difficulty and added target field. - Enhanced error handling in JsonRpcError for chain work calculations. - Updated tests to reflect changes in difficulty and chain work representation.
moisesPompilio
force-pushed
the
add-block-ext
branch
from
31bdd1d to
98b5219
Compare
Collaborator
|
ACK 98b5219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Notes
Introduces
HeaderExtension, a trait that adds shared helper functions tobitcoin::Header. As suggested in PR #682 , the goal is to centralize logic that depends on block headers and is reused across different RPC methods. This includes calculations such as chain work, median time past, and other header-derived values.By consolidating this logic in a single place, we reduce duplication, ensure consistent behavior across RPC calls, and lower the chances of errors caused by incorrect variable handling.
How to verify the changes
Check the Floresta RPC outputs for
getblockchaininfoandgetblock. The returned fields must match the corresponding values from Bitcoin Core’s RPCs for the same blocks.