Implement failed swap resolving methods #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgranhao
force-pushed
the
feature/resolve-failed-swaps
branch
3 times, most recently
from
c859d7b to
b4e494a
Compare
dleutenegger
requested changes
Oct 23, 2023
dleutenegger
approved these changes
Oct 23, 2023
andrei-21
reviewed
Oct 25, 2023
src/lipalightninglib.udl
Outdated
| sequence<FailedSwapInfo> get_unresolved_failed_swaps(); | ||
|
|
||
| [Throws=LnError] | ||
| string refund_failed_swap(string failed_swap_address, string to_address, u32 onchain_fee_rate); |
There was a problem hiding this comment.
Suggested change
| string refund_failed_swap(string failed_swap_address, string to_address, u32 onchain_fee_rate); | |
| string resolve_failed_swap(string failed_swap_address, string to_address, u32 onchain_fee_rate); |
There was a problem hiding this comment.
Applied in 6be1ed1
andrei-21
approved these changes
Oct 25, 2023
danielgranhao
force-pushed
the
feature/resolve-failed-swaps
branch
from
6be1ed1 to
e266e70
Compare
Co-authored-by: Andrei <92177534+andrei-21@users.noreply.github.com>
danielgranhao
force-pushed
the
feature/resolve-failed-swaps
branch
from
e266e70 to
8743455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.