Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecov-cli and deps #495

Closed
wants to merge 1 commit into from
Closed

Conversation

giovanni-guidini
Copy link

These changes were made by following the exact instructions on Readme.md, that is, running python3 -m add_pkg codecov-cli.

This is used in the codecov-ats.yml workflow and currently requires the extra index to Pypi to be installed.
See: https://github.com/getsentry/sentry/blob/d069119cee5dfc887cf3f0744e4c8ebdf9be8a9c/.github/workflows/codecov_ats.yml#L76C100-L76C100

These changes were made by following the exact instructions on Readme.md,
that is, running `python3 -m add_pkg codecov-cli`.

This is used in the `codecov-ats.yml` workflow and currently requires the extra
index to Pypi to be installed.
See: https://github.com/getsentry/sentry/blob/d069119cee5dfc887cf3f0744e4c8ebdf9be8a9c/.github/workflows/codecov_ats.yml#L76C100-L76C100
@giovanni-guidini giovanni-guidini requested a review from a user November 3, 2023 13:45
Comment on lines +1277 to +1278
[smart-open==6.4.0]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we factor this library out -- I really don't want people to be able to use it at sentry. it has some pretty problematic beahviour that can lead to arbitrary downloads in a security-sensitive context. open should be just fine for most usecases and if we need explicit access to alternative stores then that should be used explicitly instead of magically

Comment on lines +478 to +479
[ijson==3.2.3]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly I don't think we're processing enough json for this to be meaningful -- the stdlib json parser would be preferable

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum... are the standard libs able to stream JSON? That is the reason for us to use these libs.

I can look for alternatives so we don't include these libs. We might be able to pull it off not streaming the JSON too... In the scenario they're used we expect to parse JSONs in the few hundreds of MBs size

I'll research that. Thanks for raising concern about these libs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually ijson is dead and archived too so we definitely should not be using it

for a few 100 MB I doubt it will make a performance difference to just use stdlib json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh maybe not archived -- just the pypi url goes to the old maintainer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be clear here -- ijson is probably fine -- I don't have major concerns with it but it is unlikely to be solving the problem at hand. smart-open isn't getting you anything though -- normal open is already streamed unless you call .read() on it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get rid of smart-open. As you said it's giving us nothing.
But the ijson is serving us a purpose of parsing the JSON file without loading everything into memory. I prefer to keep it.

@giovanni-guidini
Copy link
Author

Blocked by codecov/codecov-cli#326 (to remove smart-open) and pending a new release being made

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to remove smart-open

@asottile-sentry asottile-sentry deleted the gio/add-codecov-cli branch February 7, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants