Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add codecov-cli and deps #495

Closed
wants to merge 1 commit into from
Closed

add codecov-cli and deps #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ python_versions = <3.11
[amqp==5.1.1]

[anyio==3.6.1]
[anyio==4.0.0]

[asgiref==3.5.2]
[asgiref==3.6.0]
Expand Down Expand Up @@ -146,6 +147,8 @@ brew_requires = libffi
[clickhouse-driver==0.2.4]
python_versions = <3.11

[codecov-cli==0.4.1]

[colorama==0.4.5]

[confluent-kafka==1.9.2]
Expand Down Expand Up @@ -449,11 +452,13 @@ python_versions = <3.11

[httpcore==0.11.1]
[httpcore==0.15.0]
[httpcore==0.16.3]

[httplib2==0.22.0]

[httpx==0.15.4]
[httpx==0.23.0]
[httpx==0.23.3]

[hypothesis==6.61.0]
validate_extras = pytest
Expand All @@ -470,6 +475,8 @@ validate_extras = pytest
[idna==3.3]
[idna==3.4]

[ijson==3.2.3]

Comment on lines +478 to +479
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly I don't think we're processing enough json for this to be meaningful -- the stdlib json parser would be preferable

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum... are the standard libs able to stream JSON? That is the reason for us to use these libs.

I can look for alternatives so we don't include these libs. We might be able to pull it off not streaming the JSON too... In the scenario they're used we expect to parse JSONs in the few hundreds of MBs size

I'll research that. Thanks for raising concern about these libs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually ijson is dead and archived too so we definitely should not be using it

for a few 100 MB I doubt it will make a performance difference to just use stdlib json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh maybe not archived -- just the pypi url goes to the old maintainer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be clear here -- ijson is probably fine -- I don't have major concerns with it but it is unlikely to be solving the problem at hand. smart-open isn't getting you anything though -- normal open is already streamed unless you call .read() on it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get rid of smart-open. As you said it's giving us nothing.
But the ijson is serving us a purpose of parsing the JSON file without loading everything into memory. I prefer to keep it.

[imagesize==1.4.1]

[immutables==0.15]
Expand Down Expand Up @@ -1267,6 +1274,8 @@ python_versions = <3.11

[six==1.16.0]

[smart-open==6.4.0]

Comment on lines +1277 to +1278
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we factor this library out -- I really don't want people to be able to use it at sentry. it has some pretty problematic beahviour that can lead to arbitrary downloads in a security-sensitive context. open should be just fine for most usecases and if we need explicit access to alternative stores then that should be used explicitly instead of magically

[smmap==3.0.2]

[sniffio==1.2.0]
Expand Down Expand Up @@ -1381,6 +1390,8 @@ python_versions = <3.11
[tqdm==4.64.1]
[tqdm==4.65.0]

[tree-sitter==0.20.2]

[trio==0.21.0]
[trio==0.22.2]

Expand Down