fix(pattern): Fix mongodb patterns, assert all patterns in debug profile #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/assert-patterns-in-debug
branch
from
21a2951
to
6595a85
Compare
Dav1dde
changed the title
iambriccardo
reviewed
Oct 9, 2024
jjbayer
reviewed
Oct 9, 2024
| @@ -117,7 +117,7 @@ pub fn hardcoded_span_metrics() -> Vec<(GroupKey, Vec<MetricSpec>, Vec<TagMappin | |||
| let is_db = RuleCondition::eq("span.sentry_tags.category", "db") | |||
| & !RuleCondition::glob("span.op", DISABLED_DATABASES) | |||
| // MongoDB queries are only allowed when `span.system` is set to `mongodb`. | |||
| & (RuleCondition::eq("span.system", "mongodb") | |||
There was a problem hiding this comment.
@mjq turns out this condition had the wrong field, which we did not notice because MONGODB_QUERIES contained an invalid pattern.
Dav1dde
force-pushed
the
dav1d/assert-patterns-in-debug
branch
from
fcabd08
to
30f3324
Compare
|
@jjbayer the span op fix, added a bunch of tags (and some metrics) for db spans, they seem alright to me but please double check. |
jjbayer
approved these changes
Oct 9, 2024
Dav1dde
force-pushed
the
dav1d/assert-patterns-in-debug
branch
from
30f3324
to
69dc769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert patterns for correctness in the debug profile. This caught the mongodb patterns to be broken because of unbalanced parenthesis.
Example failure of the MongoDB patterns:
Fixing the mongodb patterns surfaced a bug in matching of the
db.system, which is now also fixed.#skip-changelog