build: cargo update
#968
build: cargo update
#968
Conversation
Dav1dde
left a comment
Dav1dde
left a comment
There was a problem hiding this comment.
Makes sense, but looks like it breaks MSRV as crates may not consider MSRV for breaking changes.
|
@Dav1dde, indeed; I believe we will need to bump MSRV. I'm also thinking we may wish to define a clearer MSRV policy in the SDK; as I understand it, most crates do not consider MSRV bumps to be semver-breaking changes, so we should adopt an explicit policy as to which versions we aim to support |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/update-cargo
branch
from
0cb5f31 to
fb9917f
Compare
szokeasaurusrex
changed the base branch from
master
to
szokeasaurusrex/bump-msrv
|
@lcian's suggestion with changing the resolver is an interesting idea, because overall you're not actually changing the practical MSRV (since there still is a configuration of dependencies which satisfies the original MSRV), just CI which we use fails with the dependencies specified in this lock file. Changing MSRV overall is also fine, I would still be careful to not bump individual dependency ranges (e.g. from |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/bump-msrv
branch
from
ea7d4c6 to
c91c82f
Compare
Bump the MSRV to 1.88 to allow dependency updates (see #968). I do not think this change requires a major version bump, as our [MSRV policy](https://github.com/getsentry/sentry-rust?tab=readme-ov-file#requirements) states we try to support the last six months of Rust versions, and 1.88 is more than six months old. Stacked on #969.
2 participants
Run
cargo updateto bump all dependencies to the latest versions.Stacked on #970.