chore(grouping): Use optimized grouping logic for 100% of non-transitioning projects #77027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
lobsterkatie
force-pushed
the
kmclb-enable-optimized-transition-logic-for-100-percent-of-projects
branch
from
64ad7e7
to
d00042c
Compare
lobsterkatie
force-pushed
the
kmclb-enable-optimized-transition-logic-for-100-percent-of-projects
branch
from
d00042c
to
9ad700d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #77027 +/- ##
==========================================
- Coverage 78.16% 78.15% -0.01%
==========================================
Files 6910 6910
Lines 307185 307185
Branches 50342 50342
==========================================
- Hits 240097 240095 -2
- Misses 60720 60722 +2
Partials 6368 6368 |
mrduncan
approved these changes
Sep 6, 2024
lobsterkatie
deleted the
kmclb-enable-optimized-transition-logic-for-100-percent-of-projects
branch
c298lee
pushed a commit
that referenced
this pull request
Sep 10, 2024
…ioning projects (#77027) This is a follow-up to #76614, #76679, #76758, and #76890, enabling the updated grouping transition logic for the final 20% of non-transitioning projects. Once this is merged, we'll be able to start cleaning up the old logic in `_save_aggregate`, the checks for which path to use, etc. I didn't do that in this PR because I want to wait and let this run for a few days to make sure there are no issues before I go ripping out a bunch of code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #76614, #76679, #76758, and #76890, enabling the updated grouping transition logic for the final 20% of non-transitioning projects.
Once this is merged, we'll be able to start cleaning up the old logic in
_save_aggregate, the checks for which path to use, etc. I didn't do that in this PR because I want to wait and let this run for a few days to make sure there are no issues before I go ripping out a bunch of code.