Asynchronously schedule halo exchange with communication_object#186
Closed
msimberg wants to merge 5 commits intoghex-org:masterfrom
Closed
Asynchronously schedule halo exchange with communication_object#186msimberg wants to merge 5 commits intoghex-org:masterfrom
communication_object#186msimberg wants to merge 5 commits intoghex-org:masterfrom
Conversation
msimberg
changed the title
communication_object
Contributor
Author
|
#190 replaces this with a more explicit and cleaner solution. However, I'm leaving this branch around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #185, this is a testing branch, nowhere near ready for merging.
This branch allows removing a
cudaDeviceSynchronizebefore starting a halo exchange with GHEX. This implicitly assumes that all fields depend on the default stream. Likewise forwait, this branch removes the device/stream synchronization and instead just adds a dependency to the default stream on the unpacking streams.This is meant to evolve into something where the
communication_objectAPI explicitly allows opting into the above behaviour, instead of relying on implicit assumptions.This is also based on #184 and #182.