Move Values.metadata to Values.global.metadata #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run cluster-test-suites |
nprokopic
commented
Nov 12, 2023
nprokopic
commented
Nov 12, 2023
Merged
1 task
cluster-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: |
fiunchinho
approved these changes
Nov 14, 2023
1 task
AndiDog
approved these changes
Nov 21, 2023
This was referenced Nov 21, 2023
Merged
nprokopic
force-pushed
the
move-metadata-to-global
branch
from
288e8ef to
ea2135c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#2954
What this PR does / why we need it
We have ported all provider-independent Cluster API resources to cluster chart, which was phase 1 of restructuring of cluster- apps, see giantswarm/roadmap#2742 for more details. Now we want to use cluster chart in cluster-aws and remove all provider-independent Cluster API resources from cluster-aws.
In order to do so, first we have to refactor cluster-aws Helm values, so that cluster chart can read provider-independent values it needs. For that, we have to move current top-level properties to be under Values.global.
This pull request moves
Values.metadatatoValues.global.metadata.Compare Helm RenderingGitHub action, where it is passing old Helm values from main branch when generating old Helm templates from main branch. The action is originally (IIUC mistakenly) passing new Helm values from the current branch to the old Helm chart from the main branch.Checklist
Trigger e2e tests
/run cluster-test-suites