PP-1769: Digital Invoice sonar issue fixes #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, because cognitive complexity was very high PP-1769
obaidgini
requested review from
abolfazlimahdi,
MozhganPeivandianSharbaf and
Copilot
obaidgini
added
the
Sonar cloud fixes
There was a problem hiding this comment.
Pull Request Overview
This PR addresses SonarCloud issues by reducing cognitive complexity in the DigitalInvoice class through method extraction and refactoring.
- Extracted line item transformation logic into a separate private method to reduce cognitive complexity
- Improved code organization by separating concerns within the compound extractions processing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt
Outdated
Show resolved
Hide resolved
|
abolfazlimahdi
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue related to sonar cloud, and the cognitive complexity of one method is reduced.
Ticket# PP-1769
Notes for the reviewer
Thank you.