Skip to content

PP-1769: Digital Invoice sonar issue fixes #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: PP-1508-Monorepo-SonarQube-maintenance-bank-sdk
Choose a base branch
from
Open

PP-1769: Digital Invoice sonar issue fixes #848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79eb9ed
feat(bank-sdk): shifting the logic of transforming to separate method…
obaidgini Sep 29, 2025
5027b0f
feat(bank-sdk): Removed extra space
obaidgini Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 46 additions & 45 deletions ...-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,51 +301,7 @@ internal class DigitalInvoice(
_compoundExtractions = compoundExtractions.mapValues { (name, extraction) ->
when (name) {
"lineItems" -> {
val cameraExtractions =
extraction.specificExtractionMaps.mapIndexed { index, lineItemExtractions ->
selectableLineItems.find { it.lineItem.id.toInt() == index }
?.let { sli ->
val extractions =
lineItemExtractions.mapValues { (name, lineItemExtraction) ->
when (name) {
"description" -> copyGiniCaptureSpecificExtraction(
lineItemExtraction,
sli.lineItem.description
)

"baseGross" -> copyGiniCaptureSpecificExtraction(
lineItemExtraction,
sli.lineItem.rawGrossPrice
)

"quantity" -> copyGiniCaptureSpecificExtraction(
lineItemExtraction,
if (sli.selected) {
sli.lineItem.quantity.toString()
} else {
"0"
}
)

else -> lineItemExtraction
}
}.toMutableMap()
sli.reason?.let { returnReason ->
extractions.put(
"returnReason", GiniCaptureSpecificExtraction(
"returnReason",
returnReason.id,
"",
null,
emptyList()
)
)
}
extractions
}
}.filterNotNull().toMutableList()


val cameraExtractions = transformLineItemExtractions(extraction)
val userAddedExtractions = selectableLineItems.filter { it.addedByUser }
.map {
it.lineItem.asGiniExtractionMap()
Expand All @@ -364,6 +320,51 @@ internal class DigitalInvoice(
}
}

private fun transformLineItemExtractions(extraction: GiniCaptureCompoundExtraction): MutableList<MutableMap<String, GiniCaptureSpecificExtraction>> {
return extraction.specificExtractionMaps.mapIndexed { index, lineItemExtractions ->
selectableLineItems.find { it.lineItem.id.toInt() == index }
?.let { sli ->
val extractions =
lineItemExtractions.mapValues { (name, lineItemExtraction) ->
when (name) {
"description" -> copyGiniCaptureSpecificExtraction(
lineItemExtraction,
sli.lineItem.description
)

"baseGross" -> copyGiniCaptureSpecificExtraction(
lineItemExtraction,
sli.lineItem.rawGrossPrice
)

"quantity" -> copyGiniCaptureSpecificExtraction(
lineItemExtraction,
if (sli.selected) {
sli.lineItem.quantity.toString()
} else {
"0"
}
)

else -> lineItemExtraction
}
}.toMutableMap()
sli.reason?.let { returnReason ->
extractions.put(
"returnReason", GiniCaptureSpecificExtraction(
"returnReason",
returnReason.id,
"",
null,
emptyList()
)
)
}
extractions
}
}.filterNotNull().toMutableList()
}

fun updateAmountToPayExtractionWithTotalPrice() {
val totalPrice = getAmountToPay().toPriceString(
selectableLineItems.firstOrNull()?.lineItem?.rawCurrency ?: "EUR"
Expand Down