Conversation
Collaborator
|
Sorry @atsju, I didn't realize there was a pending PR. I'll look at this over the weekend. |
gr5
approved these changes
Sep 30, 2025
Collaborator
gr5
left a comment
gr5
left a comment
There was a problem hiding this comment.
This is a safe PR to accept. It won't change the functionality of DFTF. But it has code that Dale might want to preserve - code that might be used some day. So let's make sure Dale is okay with this PR.
Collaborator
Author
|
@githubdoe can you check this PR for removal of files you would like to keep ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#242
I removed whole bunch of unused files. Most of them date from versions 1.x and have never really been used.
I kept
PdfCalibrationDLgbecause it looks like this is something that needs to be reused. Please confirm.