-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: notification filters #1304
Conversation
I guess the settings store doesn't support storing arrays? |
it can with a bit of work 😅. give me a few minutes to tinker with that |
updated to use an array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think the extra work to make it an array was worth it :)
100000% |
@afonsojramos - looking forward to your feedback on this, too, before I merge |
…nto feat/filters
FWIW, in that last screenshot, there's no explanation text... I was looking for it and it still look me a minute to find the icon. Without the context, I'd never have guessed that's what the button does! |
Even with the hover text? 🤔 |
What about adding a counter to the filter icon on the sidebar that when hovered showed a tooltip with the filters being used which could be individually removed AND cleared? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!! 🚀 Excited for the next release 👀
New
Filter
sidebar route which contains any post filtering controls, includingWhen any non-default filters are selected, it will show a visual indicator