-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated script #5
Conversation
…t and python script for full graphlet creation pipeline. Also added two additional examples without included graphlets.
It looks like
Have you seen that error message before @csmagnano? |
I figured out the issue @agitter . The network file was not in the correct format for pgd (it had been converted on my personal computer). I updated the setup script to created a converted network file before testing pgd. This is also a plus as travis is now running the |
That's great that it all runs in Travis now. Thanks for fixing the graph input. I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There a few changes to make before merging and a few other ideas we can discuss. Some of these suggestions can instead be noted in a new issue and wait for a later round of revisions.
I'd like to continue thinking about what data is stored in the repository and what is zipped. Are we being inconsistent by zipping the Reactome .gOut
files but not the NetBox predicted .sif
files?
…ges. Fixed broken links, added installation description, other small wording changes.
…pendancy to README, and changed travis to test runPPA.sh instead of the setup script alone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. These changes close issue #1.
Closes #1
The main thing to check is that the runPPA script runs properly when trying to install pgd, and that there's no files I accidentally assumed. I've tested on my machine but it would be good to test on another.
We should also confirm how much of what I added could be tested with Travis, but that is probably okay to do until after the initial release.
This pull request fixes issues #1 and #2.