Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated script #5

Merged
merged 15 commits into from
Nov 16, 2019
Merged

Integrated script #5

merged 15 commits into from
Nov 16, 2019

Conversation

csmagnano
Copy link
Collaborator

@csmagnano csmagnano commented Nov 8, 2019

Closes #1

The main thing to check is that the runPPA script runs properly when trying to install pgd, and that there's no files I accidentally assumed. I've tested on my machine but it would be good to test on another.

We should also confirm how much of what I added could be tested with Travis, but that is probably okay to do until after the initial release.

This pull request fixes issues #1 and #2.

…t and python script for full graphlet creation pipeline. Also added two additional examples without included graphlets.
@csmagnano csmagnano requested a review from agitter November 8, 2019 23:09
@agitter
Copy link
Member

agitter commented Nov 10, 2019

It looks like make runs successfully for PDG on the Travis server and some executable is built in the expected directory. However, the test command fails with

The command "bash scripts/setupPGD.sh" failed and exited with 255 during .

Have you seen that error message before @csmagnano?

@csmagnano
Copy link
Collaborator Author

I figured out the issue @agitter . The network file was not in the correct format for pgd (it had been converted on my personal computer). I updated the setup script to created a converted network file before testing pgd. This is also a plus as travis is now running the makePGDNet.py script, and being able to run pgd on the converted network is proof it works.

@agitter
Copy link
Member

agitter commented Nov 11, 2019

That's great that it all runs in Travis now. Thanks for fixing the graph input. I removed the ls commands I was using for debugging. I'll do a more thorough review and add comments soon.

Copy link
Member

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a few changes to make before merging and a few other ideas we can discuss. Some of these suggestions can instead be noted in a new issue and wait for a later round of revisions.

I'd like to continue thinking about what data is stored in the repository and what is zipped. Are we being inconsistent by zipping the Reactome .gOut files but not the NetBox predicted .sif files?

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
data/Prolactin/README.md Outdated Show resolved Hide resolved
data/Wnt/README.md Outdated Show resolved Hide resolved
scripts/makePGDNet.py Outdated Show resolved Hide resolved
scripts/runPPA.sh Show resolved Hide resolved
scripts/runPPA.sh Show resolved Hide resolved
scripts/runPPA.sh Outdated Show resolved Hide resolved
scripts/runPPA.sh Outdated Show resolved Hide resolved
scripts/setupPGD.sh Show resolved Hide resolved
Copy link
Member

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. These changes close issue #1.

@agitter agitter merged commit ee875d0 into master Nov 16, 2019
@agitter agitter deleted the integratedScript branch November 16, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add script showing how to use PGD on raw pathways.
2 participants