Merged
Conversation
It's a bit unclear whether `1.` is a legal float, and the previous change was making Marshal create EDN which couldn't be parsed back. Some tests to catch that potential problem.
Contributor
Author
|
Just realized the old fix led to floating point numbers that go-edn wasn't happy to parse back. I see in the source that this is intentionally true to the spec and not clojure. Filed a PR against the spec anyway: edn-format/edn#76 |
Member
|
Thanks, looks good :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.0used to be encoded to1, which is an integer.