Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pipeline): use server API types for pipeline and migrate compiler types #1200

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Oct 3, 2024

  • nested API type for pipeline
  • preloading only for DB functions where the related resource is not already present in the function arguments
  • moving all the compiler types over (yaml, pipeline, raw)

@ecrupper ecrupper requested a review from a team as a code owner October 3, 2024 17:08
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 91.51724% with 123 lines in your changes missing coverage. Please review.

Project coverage is 56.16%. Comparing base (2960513) to head (30ea176).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
compiler/types/pipeline/container.go 81.45% 21 Missing and 7 partials ⚠️
compiler/types/pipeline/ruleset.go 80.58% 10 Missing and 10 partials ⚠️
compiler/types/pipeline/build.go 72.88% 11 Missing and 5 partials ⚠️
util/compression.go 54.54% 5 Missing and 5 partials ⚠️
compiler/types/yaml/template.go 73.07% 7 Missing ⚠️
compiler/types/pipeline/secret.go 94.11% 2 Missing and 2 partials ⚠️
compiler/types/raw/map.go 92.30% 2 Missing and 2 partials ⚠️
compiler/types/yaml/build.go 91.66% 2 Missing and 2 partials ⚠️
compiler/types/yaml/secret.go 95.69% 2 Missing and 2 partials ⚠️
compiler/types/yaml/service.go 89.74% 2 Missing and 2 partials ⚠️
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1200      +/-   ##
==========================================
+ Coverage   53.04%   56.16%   +3.12%     
==========================================
  Files         559      584      +25     
  Lines       19743    21288    +1545     
==========================================
+ Hits        10473    11957    +1484     
- Misses       8701     8717      +16     
- Partials      569      614      +45     
Files with missing lines Coverage Δ
api/build/auto_cancel.go 18.18% <ø> (ø)
api/build/executable.go 0.00% <ø> (ø)
api/build/graph.go 0.00% <ø> (ø)
api/build/plan.go 0.00% <ø> (ø)
api/build/skip.go 100.00% <ø> (ø)
api/pipeline/compile.go 60.00% <ø> (ø)
api/pipeline/template.go 0.00% <ø> (ø)
api/service/plan.go 0.00% <ø> (ø)
api/step/plan.go 0.00% <ø> (ø)
api/types/build.go 99.11% <ø> (+7.34%) ⬆️
... and 72 more

... and 1 file with indirect coverage changes

compiler/types/pipeline/ruleset.go Show resolved Hide resolved
compiler/types/yaml/stage.go Show resolved Hide resolved
compiler/types/yaml/stage.go Show resolved Hide resolved
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 67a8e47 into main Oct 11, 2024
13 of 16 checks passed
@ecrupper ecrupper deleted the refactor/nested-api/pipeline branch October 11, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants