Reduce outer inspector margins

[passivestar]

Reduces inspector margins leaving the same outer gap in modern theme as it is in classic. Should fix #112284

Master	PR

Modern	Classic

[groud]

It helps, but IMO the problem is maybe a bit there now:

[passivestar]

@groud I found that the extra margin is coming from the focus stylebox. While it can be reduced, it can't be reduced all the way to zero because then there will be no space to draw the focus border:

If it can't be reduced to zero then it's probably better to leave at current value because a 2px misalignment would be much more triggering than a regular padding that looks intentional.

If focus wasn't an issue then I'd say aligning those would require slightly increasing the margin of the dock (around everything including header) because otherwise that loss of inner space is starting to get noticeable and it's starting to look a bit heavy:

[groud]

Well to align things maybe we could also add some padding around the header part, and maybe compensate by reducing whole dock padding accordingly ? Then we can adjust everything with the dock's padding.

If it can't be reduced to zero then it's probably better to leave at current value because a 2px misalignment would be much more triggering than a regular padding that looks intentional.

True.

[ErnSur]

If focus wasn't an issue then I'd say aligning those would require slightly increasing the margin of the dock (around everything including header) because otherwise that loss of inner space is starting to get noticeable and it's starting to look a bit heavy:

@passivestar Are you saying that the visuals on the second screenshot you attached are bad?
I'd say they finally look correct to me.

I was looking for a PR like this because ever since I started working with Godot I was irked by the unnecessary extra margin around many of the UI elements. It's very noticeable if you're working on a laptop.
Here are some examples:

[passivestar]

@passivestar Are you saying the the visuals on the second screenshot you attached are bad?
I'd say they finally look correct to me.

Aligning those is good but the dock could use a few more pixels of horizontal padding

I was looking for a PR like this because ever since I started working with Godot I was irked by the unnecessary extra padding around many of the UI elements. It's very noticeable if you're working on a laptop.

You don't need a PR to reduce all paddings at once, there's a "Base Spacing" editor setting that you can use. But it shouldn't be too crammed by default

[ErnSur]

You don't need a PR to reduce all paddings at once, there's a "Base Spacing" editor setting that you can use. But it shouldn't be too crammed by default

I'd say that the problem is that too many elements use the base spacing into consideration. Some UI containers should simply ignore it since they hierarchy ancestor already takes care of it.

Let's say I'm designing a Inspector UI hierarchy like so:

• VBox
  • HBox
    • SearchBox
    • Button
  • TreeView

If I apply a horizontal margin to the first VBox then I don't want to apply the extra margin to "HBox". Its there to simply layout other elements.

Here's the Inspector window with the base spacing set to 8. I'm arguing that the headers should not have the extra indent and the scroll bar should stick to the right window border and the margin space should be applied to the left of it instead.