Remove GDExtension compatibility code for Godot 4.0 #77963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jun 7, 2023
RedworkDE
reviewed
Jun 7, 2023
dsnopek
force-pushed
the
remove-gdextension-legacy-struct
branch
from
31a8366 to
ef9cb79
Compare
mhilbrunner
approved these changes
Jun 8, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that PR #77410 has been merged, there is no way to allow GDExtensions built for Godot 4.0 to work with Godot 4.1.
So, this PR remove all the compatibility code that allowed that to work, so that Godot 4.1+ will simply refuse to load a GDExtension made for Godot 4.0 with a nice message (as opposed to crashing :-)).