C#: Fix attributes for sln/csproj files
#91479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: Nevermind I saw |
aaronfranke
reviewed
May 2, 2024
Repiteo
force-pushed
the
dotnet/sln-csproj-attributes
branch
from
1efc457
to
95f9f51
Compare
raulsntos
reviewed
May 3, 2024
Repiteo
force-pushed
the
dotnet/sln-csproj-attributes
branch
from
95f9f51
to
97ec971
Compare
Repiteo
force-pushed
the
dotnet/sln-csproj-attributes
branch
from
97ec971
to
64f2e8b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows can get somewhat finicky when handling
.sln/.csprojfiles if the encoding isn't tailored to it specifically, and most of those files in our repo aren't doing so. This PR rectifies this issue by explicitly changing their encoding/eol fromutf-8/lftoutf-8-bom/crlf. Tweaked.gitattributesand mono's.editorconfigto account for these changes.Additionally, this fixed formatting in a handful of
.csprojfiles and all.slnfiles. The former was two cases where tab indentation was 4 instead of 2. The latter was updating the solutions to their modern schema, which fixed some icon bugs on Windows (shell extensions are very picky).