-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: add partitioned attribute to cookie type #62499
Conversation
This PR (HEAD: a60c247) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/526435. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
This PR (HEAD: 133e1a5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/526435. Important tips:
|
Message from Ian Lance Taylor: Patch Set 2: Hold+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
This PR (HEAD: 4b03a0a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/526435. Important tips:
|
This PR (HEAD: 78ddb80) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/526435. Important tips:
|
Message from Théo Dury: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Fixes #62490 net/http: fix test case for TestCookieValid net/http: add missing continue for readSetCookies
This PR (HEAD: 2d33084) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/526435. Important tips:
|
This PR (HEAD: 46e1cb3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/526435. Important tips:
|
Message from Damien Neil: Patch Set 6: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Message from shude li: Patch Set 6: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
This PR (HEAD: e581799) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/526435. Important tips:
|
Message from shude li: Patch Set 9: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
This PR (HEAD: 7df8738) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/526435. Important tips:
|
Message from Damien Neil: Patch Set 10: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-22T16:20:22Z","revision":"9d66cc237b8d0c29c812718f8611c919516a467b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Message from Damien Neil: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Message from Go LUCI: Patch Set 10: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Message from Damien Neil: Patch Set 10: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Message from Dmitri Shuralyov: Patch Set 10: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Message from Théo Dury: Patch Set 10: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/526435. |
Fixes #62490 Change-Id: Ibe7df96f50275c9321462e994a962031cb1f3018 GitHub-Last-Rev: 7df8738 GitHub-Pull-Request: #62499 Reviewed-on: https://go-review.googlesource.com/c/go/+/526435 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Théo Dury <tdury2@gmail.com>
This PR is being closed because golang.org/cl/526435 has been merged. |
Fixes #62490