Isolate metrics transmission logic #1717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need to be rebased once #1715 merges |
cjreynol
force-pushed
the
isolate_metrics_transmit
branch
2 times, most recently
from
3475277 to
183f508
Compare
This new file will be the home of related metrics transmission logic from `host/libs/metrics/send`. Bug: 452136634
cjreynol
force-pushed
the
isolate_metrics_transmit
branch
from
183f508 to
f5f0b11
Compare
Moving over `send.h/cc` logic into `metrics_transmitter.h/cc`. This way we can use a `Result` to surface errors, or make other improvements without concern for modifying the original metrics code. Bug: 452136634
cjreynol
force-pushed
the
isolate_metrics_transmit
branch
from
f5f0b11 to
fd7dfa9
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
jemoreira
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy over and modify the v1 metrics logic. This lets us make modifications (like using
Resultfor errors) without worrying about breaking v1 metrics logic. Eventually, the v1 logic will be removed in favor of this new code.Bug: 452136634