Fix broken error-message formatting in flax.nnx#5334
Fix broken error-message formatting in flax.nnx#5334gdrosa wants to merge 1 commit intogoogle:mainfrom
Conversation
Two string formatting bugs:
1. filterlib.to_predicate: `{filter:!r}` → `{filter!r}`
(malformed f-string raised ValueError instead of intended TypeError)
Reproduce:
>>> import flax.nnx.filterlib as filterlib
>>> filterlib.to_predicate(37)
ValueError: Invalid format specifier '!r' for object of type 'int'
2. variablelib.variable_name_from_type: added missing `f` prefix
(error showed literal `{name}` placeholders instead of actual values)
Reproduce:
>>> from flax.nnx import Variable
>>> from flax.nnx.variablelib import variable_name_from_type
>>> class params(Variable): pass
>>> variable_name_from_type(params, allow_register=True)
ValueError: Name {name} is already registered in the registry as
{VariableTypeCache[name]}. It cannot be linked with this type {typ}.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses two distinct issues related to error message formatting within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses two formatting bugs in error messages within the flax.nnx module. The first change in flax/nnx/filterlib.py corrects an invalid f-string format specifier, preventing a ValueError during error handling. The second change in flax/nnx/variablelib.py adds the necessary f prefix to an error string to ensure proper interpolation of variables. Both fixes are correct and directly resolve the issues described. The changes are well-implemented and improve the robustness of error reporting.
2 participants
Summary
filterlib.to_predicate:{filter:!r}→{filter!r}fprefix invariablelib.variable_name_from_typeerror stringBoth bugs cause error paths to crash with confusing secondary errors instead of showing the intended messages.
Steps to reproduce
to_predicate(raisesValueError: Invalid format specifier '!r'instead of the intendedTypeError):variable_name_from_type(shows literal{name}placeholders instead of actual values):Test plan