Skip to content

Fix broken error-message formatting in flax.nnx #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdrosa wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix broken error-message formatting in flax.nnx #5334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flax/nnx/filterlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def to_predicate(filter: Filter) -> Predicate:
elif isinstance(filter, (list, tuple)):
return Any(*filter)
else:
raise TypeError(f'Invalid collection filter: {filter:!r}. ')
raise TypeError(f'Invalid collection filter: {filter!r}. ')

def filters_to_predicates(
filters: tp.Sequence[Filter],
Expand Down
4 changes: 2 additions & 2 deletions flax/nnx/variablelib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2292,8 +2292,8 @@ def variable_name_from_type(
name = typ.__name__
if name in VariableTypeCache:
raise ValueError(
'Name {name} is already registered in the registry as {VariableTypeCache[name]}. '
'It cannot be linked with this type {typ}.'
f'Name {name} is already registered in the registry as {VariableTypeCache[name]}. '
f'It cannot be linked with this type {typ}.'
)
register_variable_name(name, typ)
return name
Expand Down
Loading