-
Notifications
You must be signed in to change notification settings - Fork 138
Update github actions for E2E test #3429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreia-ferreira
wants to merge
14
commits into
master
Choose a base branch
from
andreia/3365/update-github-actions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3429 +/- ##
============================================
- Coverage 70.07% 70.02% -0.06%
+ Complexity 1613 1604 -9
============================================
Files 322 322
Lines 8634 8646 +12
Branches 951 949 -2
============================================
+ Hits 6050 6054 +4
- Misses 2007 2017 +10
+ Partials 577 575 -2 🚀 New features to boost your workflow:
|
…ator to be running
d4c9f2d to
e6b279d
Compare
Comment on lines
+59
to
+63
| needs: build | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/master' | ||
| uses: ./.github/workflows/test-e2e.yml | ||
| secrets: | ||
| MAPS_API_KEY: ${{ secrets.MAPS_API_KEY }} |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3365
This PR updates the existing GitHub action files for running the Android tests.
The workflow defined in
test-e2e.ymlwill run on every push to master, but it can also be triggered manually if needed. This workflow triggers thestart-emulatoraction ofground-platformin order to start the Firebase emulator and then thesubmit-testonground-androidin order to start the Android emulator and run the tests in thee2eTestmodule.While testing this workflow some changes had to be implemented in order to make the tests less flaky:
You can see how the workflow run would look like here: https://github.com/andreia-ferreira/ground-android/actions/runs/21182506715
PTAL @shobhitagarwal1612 @gino-m