Integrate Auth Utils into ViewTrips Components #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3-2020 into authutils-converting
…e ones in trips-container.js.
…serUidArrFromUserEmailArr in auth utils.
zghera
changed the title
zghera
changed the title
zghera
changed the title
anan-ya-y
approved these changes
Jul 30, 2020
keiffer01
approved these changes
Jul 30, 2020
HiramSilvey
requested changes
Jul 31, 2020
3 tasks
HiramSilvey
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Integrate the remaining functions from AuthUtils into the ViewTrips directory components and delete fake Auth utils.
Is this fixing an issue?
Fixes #55: Integrated the "real" Auth Util functions in to all current uses within the
ViewTripsandUtilsdirectories.Fixes #111: Because of the alphabetization of the user emails, there was a need to move the current user to the front of the array of emails that is passed as default form values when editing a trip. As a result this need, the implementation provides a working fix for #111.
Are there more details that are relevant?
none
Check lists (check
xin[ ]of list items)Updated tests in 'filter-input.test.js
andtrip.js`.Any additional comments?