Conversation
There was a problem hiding this comment.
Pull request overview
This PR increases the polling interval for GitHub workflow completion checks from 15 to 30 seconds. The change affects the wait_for_completion method in the GitHub launcher, which polls the GitHub API to monitor workflow run status until completion or timeout.
Key Changes:
- Doubled the polling interval from 15 to 30 seconds in the workflow status checking loop
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| await callback(self) | ||
| await asyncio.sleep(15) # Yield control while waiting | ||
| await asyncio.sleep(30) # Yield control while waiting |
There was a problem hiding this comment.
This polling interval is hardcoded as a magic number. Consider defining it as a named constant (e.g., GITHUB_POLL_INTERVAL_SEC) in consts.py, similar to how HEARTBEAT_SEC is defined in background_submission_manager.py. This would improve maintainability and make it easier to adjust the polling interval if needed in the future.
|
|
||
| await callback(self) | ||
| await asyncio.sleep(15) # Yield control while waiting | ||
| await asyncio.sleep(30) # Yield control while waiting |
There was a problem hiding this comment.
Doubling the polling interval from 15 to 30 seconds means that completed workflows will be detected up to 30 seconds later on average, which could impact user experience. Consider making this configurable through a parameter or constant, so it can be tuned based on actual GitHub API rate limits or usage patterns rather than being a fixed value.
1 participant
No description provided.