Skip to content

Feat: add longer polling #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
S1ro1 merged 1 commit into from
Dec 17, 2025
Merged

Feat: add longer polling #381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libkernelbot/launchers/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ async def wait_for_completion(
return

await callback(self)
await asyncio.sleep(15) # Yield control while waiting
await asyncio.sleep(30) # Yield control while waiting
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This polling interval is hardcoded as a magic number. Consider defining it as a named constant (e.g., GITHUB_POLL_INTERVAL_SEC) in consts.py, similar to how HEARTBEAT_SEC is defined in background_submission_manager.py. This would improve maintainability and make it easier to adjust the polling interval if needed in the future.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubling the polling interval from 15 to 30 seconds means that completed workflows will be detected up to 30 seconds later on average, which could impact user experience. Consider making this configurable through a parameter or constant, so it can be tuned based on actual GitHub API rate limits or usage patterns rather than being a fixed value.

Copilot uses AI. Check for mistakes.
except TimeoutError:
raise # Re-raise the specific TimeoutError from the timeout block
except Exception as e:
Expand Down
Loading