Skip to content

Skip MI300x8 tests since the machines are no longer available#393

Merged
msaroufim merged 1 commit intomainfrom
mi300_test_fix
Jan 7, 2026
Merged

Skip MI300x8 tests since the machines are no longer available#393
msaroufim merged 1 commit intomainfrom
mi300_test_fix

Conversation

@msaroufim
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 7, 2026 07:30
@msaroufim msaroufim merged commit d85c9ee into main Jan 7, 2026
9 checks passed
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the test suite to skip tests for MI300x8 GPU machines, which are no longer available. The changes ensure that tests no longer attempt to run on infrastructure that doesn't exist.

Key changes:

  • Removed MI300x8 from the parametrized GPU types in test_github_launcher_python_script, leaving only NVIDIA
  • Added @pytest.mark.skip decorator to test_github_launcher_multi_gpu with an appropriate reason
  • Added a note in the docstring explaining why the test is skipped

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 206 to +209
Test GitHubLauncher with a real Python script using real GitHub Actions.
Tests all GPU types to verify runners are working.

Note: This test is skipped because MI300x8 machines are no longer available.
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring states "Tests all GPU types to verify runners are working" but this test only tests MI300x8 and is now being skipped. Since the test is skipped, consider updating the docstring to clarify that this was a multi-GPU specific test for MI300x8 machines, rather than implying it tests all GPU types.

Suggested change
Test GitHubLauncher with a real Python script using real GitHub Actions.
Tests all GPU types to verify runners are working.
Note: This test is skipped because MI300x8 machines are no longer available.
Multi-GPU test of GitHubLauncher with a real Python script using real GitHub Actions,
specifically targeting MI300x8 GitHub runners to verify they are working.
Note: This test is currently skipped because MI300x8 machines are no longer available.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments