Skip MI300x8 tests since the machines are no longer available#393
Merged
Skip MI300x8 tests since the machines are no longer available#393
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the test suite to skip tests for MI300x8 GPU machines, which are no longer available. The changes ensure that tests no longer attempt to run on infrastructure that doesn't exist.
Key changes:
- Removed MI300x8 from the parametrized GPU types in
test_github_launcher_python_script, leaving only NVIDIA - Added
@pytest.mark.skipdecorator totest_github_launcher_multi_gpuwith an appropriate reason - Added a note in the docstring explaining why the test is skipped
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
206
to
+209
| Test GitHubLauncher with a real Python script using real GitHub Actions. | ||
| Tests all GPU types to verify runners are working. | ||
|
|
||
| Note: This test is skipped because MI300x8 machines are no longer available. |
There was a problem hiding this comment.
The docstring states "Tests all GPU types to verify runners are working" but this test only tests MI300x8 and is now being skipped. Since the test is skipped, consider updating the docstring to clarify that this was a multi-GPU specific test for MI300x8 machines, rather than implying it tests all GPU types.
Suggested change
| Test GitHubLauncher with a real Python script using real GitHub Actions. | |
| Tests all GPU types to verify runners are working. | |
| Note: This test is skipped because MI300x8 machines are no longer available. | |
| Multi-GPU test of GitHubLauncher with a real Python script using real GitHub Actions, | |
| specifically targeting MI300x8 GitHub runners to verify they are working. | |
| Note: This test is currently skipped because MI300x8 machines are no longer available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.